New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663772 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Sheriff-o-matic comment box is not focused after clicking comment button

Project Member Reported by sullivan@chromium.org, Nov 9 2016

Issue description

What steps will reproduce the problem?
(1) Open up https://sheriff-o-matic.appspot.com/chromium.perf
(2) Click the comment button on an alert (message box plus "(0)")
(3) Dialog comes up, start typing

What is the expected result?

Textbox is focused and text you type goes in the box

What happens instead?

Text does not go into comment box until I focus it manually.
 
Labels: Milestone-UX
Owner: zhangtiff@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/99bf067c9c34f8fc1dacc91a585bd5b6672f93dc

commit 99bf067c9c34f8fc1dacc91a585bd5b6672f93dc
Author: Tiffany Zhang <zhangtiff@google.com>
Date: Fri Nov 11 21:37:32 2016

SoM: Autofocus on comments box.

BUG= 663772 

Change-Id: Ic212f33a574de98558489e4fe0e2ac6484419211
Reviewed-on: https://chromium-review.googlesource.com/410242
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/99bf067c9c34f8fc1dacc91a585bd5b6672f93dc/go/src/infra/appengine/sheriff-o-matic/elements/som-annotations.html

Status: Fixed (was: Untriaged)
Fix landed. Should be deployed in the next update for Sheriff-o-Matic. 

Sign in to add a comment