New issue
Advanced search Search tips

Issue 663749 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Push ninja 1.7.2 to depot_tools

Project Member Reported by thakis@chromium.org, Nov 9 2016

Issue description

Like  issue 607268  but for 1.7.2
 
Mac binary.

$ git fetch upstream --tags
$ git checkout v1.7.2
$ CFLAGS="-isysroot$(xcrun --sdk macosx10.10 -show-sdk-path) -mmacosx-version-min=10.6 -stdlib=libstdc++" LDFLAGS="-isysroot$(xcrun --sdk macosx10.10 -show-sdk-path) -mmacosx-version-min=10.6 -stdlib=libstdc++" CXX=$HOME/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang++ ./configure.py 
# This requires editing MinimumSDKVersion in /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Info.plist so that Xcode 8 accepts the 10.10 SDK :-/

thakis-macpro:ninja thakis$ ninja
[14/14] LINK ninja
thakis-macpro:ninja thakis$ ./ninja all
[24/24] LINK ninja_test
thakis-macpro:ninja thakis$ ./ninja_test
[225/225] ElideMiddle.ElideInTheMiddle
passed
thakis-macpro:ninja thakis$ otool -l ninja | grep VERSION_MIN -A 4
      cmd LC_VERSION_MIN_MACOSX
  cmdsize 16
  version 10.6
      sdk 10.10
Load command 10
thakis-macpro:ninja thakis$ strip ninja
thakis-macpro:ninja thakis$ otool -L ninja
ninja:
	/usr/lib/libstdc++.6.dylib (compatibility version 7.0.0, current version 104.1.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1213.0.0)
thakis-macpro:ninja thakis$ ./ninja --version
1.7.2
thakis-macpro:ninja thakis$ ls -l ninja
-rwxr-xr-x  1 thakis  eng  180756 Nov  9 11:16 ninja

ninja-mac
176 KB View Download
linux64

CXX="$HOME/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang++" CFLAGS="--sysroot=$HOME/src/chrome/src/build/linux/debian_wheezy_amd64-sysroot" LDFLAGS="--sysroot=$HOME/src/chrome/src/build/linux/debian_wheezy_amd64-sysroot" ./configure.py 
warning: A compatible version of re2c (>= 0.11.3) was not found; changes to src/*.in.cc will not affect your build.
wrote build.ninja.
thakis@thakis:~/src/ninja$ ninja
[24/24] LINK ninja
thakis@thakis:~/src/ninja$ ./ninja all
[27/27] LINK ninja_test
thakis@thakis:~/src/ninja$ ./ninja_test 
[226/226] ElideMiddle.ElideInTheMiddle
passed
thakis@thakis:~/src/ninja$ strip ninja
thakis@thakis:~/src/ninja$ ./ninja --version
1.7.2
thakis@thakis:~/src/ninja$ objdump -x ninja | grep GLIBC
    0x0d696914 0x00 05 GLIBC_2.4
    0x09691a75 0x00 03 GLIBC_2.2.5
    0x08922974 0x00 02 GLIBCXX_3.4
thakis@thakis:~/src/ninja$ ls -l ninja
-rwxr-x--- 1 thakis eng 179336 Nov  9 11:40 ninja

ninja-linux64
175 KB View Download
linux32

thakis@thakis:~/src/ninja$ CXX="$HOME/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang++" CFLAGS="-m32 -D_FILE_OFFSET_BITS=64 --sysroot=$HOME/src/chrome/src/build/linux/debian_wheezy_i386-sysroot" LDFLAGS="--sysroot=$HOME/src/chrome/src/build/linux/debian_wheezy_i386-sysroot -m32 -L$HOME/src/chrome/src/build/linux/debian_wheezy_i386-sysroot/usr/lib/i386-linux-gnu -Wl,-rpath-link=$HOME/src/chrome/src/build/linux/debian_wheezy_i386-sysroot/usr/lib/i386-linux-gnu" ./configure.py 
warning: A compatible version of re2c (>= 0.11.3) was not found; changes to src/*.in.cc will not affect your build.
wrote build.ninja.
thakis@thakis:~/src/ninja$ ninja
[24/24] LINK ninja
thakis@thakis:~/src/ninja$ ./ninja all
[19/27] CXX build/subprocess_test.o
src/subprocess_test.cc:228:23: warning: format specifies type 'unsigned long' but the argument has type 'rlim_t' (aka 'unsigned long long') [-Wformat]
           kNumProcs, rlim.rlim_cur);
                      ^~~~~~~~~~~~~
1 warning generated.
[27/27] LINK ninja_test
thakis@thakis:~/src/ninja$ ./ninja_test 
[226/226] ElideMiddle.ElideInTheMiddle
passed
thakis@thakis:~/src/ninja$ ./ninja --version
1.7.2
thakis@thakis:~/src/ninja$ strip ninja
thakis@thakis:~/src/ninja$ objdump -x ninja | grep GLIBC
    0x0d696910 0x00 06 GLIBC_2.0
    0x08922974 0x00 03 GLIBCXX_3.4
    0x0d696914 0x00 09 GLIBC_2.4
    0x0d696911 0x00 08 GLIBC_2.1
    0x09691f73 0x00 05 GLIBC_2.1.3
    0x0d696912 0x00 04 GLIBC_2.2
    0x0d696910 0x00 02 GLIBC_2.0
thakis@thakis:~/src/ninja$ file ninja
ninja: ELF 32-bit LSB  executable, Intel 80386, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.26, BuildID[sha1]=31e8b94917d558c86cf04267d44cedc15ae6634e, stripped
thakis@thakis:~/src/ninja$ cp ninja ~/ninja-linux32

ninja-linux32
149 KB View Download
Windows (again 64-bit with clang-cl and a MSVC2013 shell)

C:\src\ninja>ninja.bootstrap.exe
[20/28] CXX build\minidump-win32.obj
src\minidump-win32.cc(38,22) :  warning: format specifies type 'int' but the argument has type 'DWORD' (aka 'unsigned lo
ng') [-Wformat]
          temp_path, GetCurrentProcessId());
                     ^~~~~~~~~~~~~~~~~~~~~
1 warning generated.
[24/28] CXX build\disk_interface.obj
src\disk_interface.cc(88,55) :  warning: missing field 'dwMajorVersion' initializer [-Wmissing-field-initializers]
  OSVERSIONINFO version_info = { sizeof(version_info) };
                                                      ^
src\disk_interface.cc(89,8) :  warning: 'GetVersionExA' is deprecated [-Wdeprecated-declarations]
  if (!GetVersionEx(&version_info))
       ^
C:\Program Files (x86)\Windows Kits\8.1\include\um\sysinfoapi.h(449,23) :  note: expanded from macro 'GetVersionEx'
#define GetVersionEx  GetVersionExA
                      ^
C:\Program Files (x86)\Windows Kits\8.1\include\um\sysinfoapi.h(433,1) :  note: 'GetVersionExA' has been explicitly mark
ed deprecated here
GetVersionExA(
^
2 warnings generated.
[28/28] LINK ninja.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance

C:\src\ninja>ninja --version
1.7.2

C:\src\ninja>ninja all
[9/29] LINK depfile_parser_perftest.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance
[11/29] LINK canon_perftest.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance
[16/29] LINK hash_collision_bench.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance
[20/29] LINK build_log_perftest.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance
[22/29] LINK manifest_parser_perftest.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance
[29/29] LINK ninja_test.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance

C:\src\ninja>ninja_test
to stderr MSVCHelperTest.NoReadOfStderr

passed

ninja.exe
390 KB Download
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/28a1ff42d9477f548a37afc89813012b673b406c

commit 28a1ff42d9477f548a37afc89813012b673b406c
Author: thakis <thakis@chromium.org>
Date: Wed Nov 09 17:29:10 2016

Updata ninja to v1.7.2.

New binaries for Mac, Linux32, Linux64, Windows.  Also update shell script.
See the bug for how these were built.
The main "new" thing is a regression fix where 1.7.1 broke %e %r in
NINJA_STATUS.

BUG= 663749 

Review-Url: https://codereview.chromium.org/2489023002

[modify] https://crrev.com/28a1ff42d9477f548a37afc89813012b673b406c/ninja
[modify] https://crrev.com/28a1ff42d9477f548a37afc89813012b673b406c/ninja-linux32
[modify] https://crrev.com/28a1ff42d9477f548a37afc89813012b673b406c/ninja-linux64
[modify] https://crrev.com/28a1ff42d9477f548a37afc89813012b673b406c/ninja-mac
[modify] https://crrev.com/28a1ff42d9477f548a37afc89813012b673b406c/ninja.exe

Status: Fixed (was: Started)

Sign in to add a comment