New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663707 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

System freeze when switched to Virtual Terminal with UDL/DisplayLink device plugged in

Reported by lukasz.s...@displaylink.com, Nov 9 2016

Issue description

Chrome OS Version: <From about:version: 56.0.2908.0>

When system is switched to VT2(developer-console) mode with the external display via USB Dock/Adapter, and system will has no any response if the one of the following change made. 
- Unplug the external monitor from USB dock/adapter
- Unplug the USB dock/adapter
- switch to VT2(normal) mode

Steps To Reproduce:
1. Power Up the Chromebook
2. Login to the Chrome OS
3. Connect Dell D1000/UDL to the Chromebook
4. Connect the external monitor to Dell's USB dock/adapter
5. Switch to VT2 mode (by Ctrl+Alt+F2)
6. Switch to VT1 mode (by Ctrl+Alt+F1)
   or unplug the monitor from USB Dock/Adapter
   or unplug the USB Dock/Adapter

Issue is reproducible both with devices using UDL and evdi module.

Expected Result:
No freeze after switch to VT2 mode

Actual Result:
Always

 
Issue is reproducible on Dell Chromebook 13(lulu board) - kernel 3.14

To recover from freeze it is required to unplug DisplayLink device which is quite strange. Maybe the switch to VT mode is not finished hence we see that hang.
So in nutshell, the problem is that after switching to VT2 you can't go back to VT1... unless you unplug the docking station first, then try to switch, and reconnect the dock when the graphical interface is back. After these steps, both built-in and docked screens work again.

This is reproducible with both UDL and evdi.
Cc: marc...@chromium.org bhthompson@chromium.org displaylink@chromium.org
Owner: dbehr@chromium.org
Dominik, is this something in your jurisdiction?

In general this is probably a nice to fix, not a release blocker, since VT2 is a dev mode only concept and the primary concern is normal mode. So if this turns out to be complex to fix it may be left as is indefinitely.

The easy work around would be to use the ctrl+alt+t terminal, running `shell` there gives you a similar effect to VT2. 

Comment 4 by dbehr@chromium.org, Nov 10 2016

Status: Started (was: Unconfirmed)
Yep, found the problem in frecon. We were leaking UDL devices, fix upcoming.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/frecon/+/45896023df222fd0cc1e075a9392b414bd42330b

commit 45896023df222fd0cc1e075a9392b414bd42330b
Author: Dominik Behr <dbehr@chromium.org>
Date: Thu Nov 10 22:12:59 2016

frecon: fix a leak of  DRM device

When we scan DRM devices we fail to destroy DRM device that we are not going
to use. Because of how devices are ordered we did not hit this problem with
VGEM, now we do with UDL. It also prevented using UDL immediately after boot.

BUG= chromium:663707 
TEST=boot Chrome OS with UDL connected, switch to frecon and back to Chrome.

Change-Id: Ic1d76d93557af0f02a40dcc68b6ad61c565a5fe4
Signed-off-by: Dominik Behr <dbehr@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/410221
Reviewed-by: Haixia Shi <hshi@chromium.org>

[modify] https://crrev.com/45896023df222fd0cc1e075a9392b414bd42330b/drm.c

Labels: Merge-Request-55
Cc: yueherngl@chromium.org stevenh@chromium.org
Labels: -Merge-Request-55 Merge-Rejected-55
This only matters in dev mode, why would we need to merge this into 55?

Assuming rejected for now.

Comment 9 by dbehr@chromium.org, Nov 11 2016

Labels: -Merge-Rejected-55 Merge-Requested-55
Actually, it fixes more than just dev mode.
If you boot with UDL connected, frecon creates UDL DRM device which has master and because it leaks it, it keeps master and Chrome cannot get it. So Chrome cannot initalize UDL display when it starts and you will see blank screen on UDL.
You will have to disconnect and connect it back to see something.

I suspect this change may fix some complaints that people have about USB docks with DisplayLink displays.
Labels: -Pri-3 -Merge-Requested-55 M-55 Merge-Approved-55 Pri-2
Ok, that is reasonable, thanks for the clarification, please feel free to merge at your convenience.
Thanks Bernie, Dominik.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 12 2016

Labels: merge-merged-release-R55-8872.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/frecon/+/c2f9d1522e7a8df2aa4396f692c0f1cf93cf3e02

commit c2f9d1522e7a8df2aa4396f692c0f1cf93cf3e02
Author: Dominik Behr <dbehr@chromium.org>
Date: Thu Nov 10 22:12:59 2016

frecon: fix a leak of  DRM device

When we scan DRM devices we fail to destroy DRM device that we are not going
to use. Because of how devices are ordered we did not hit this problem with
VGEM, now we do with UDL. It also prevented using UDL immediately after boot.

BUG= chromium:663707 
TEST=boot Chrome OS with UDL connected, switch to frecon and back to Chrome.

Change-Id: Ic1d76d93557af0f02a40dcc68b6ad61c565a5fe4
Signed-off-by: Dominik Behr <dbehr@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/410221
Reviewed-by: Haixia Shi <hshi@chromium.org>
(cherry picked from commit 45896023df222fd0cc1e075a9392b414bd42330b)
Reviewed-on: https://chromium-review.googlesource.com/410268
Reviewed-by: YH Lin <yueherngl@chromium.org>
Commit-Queue: YH Lin <yueherngl@chromium.org>
Tested-by: YH Lin <yueherngl@chromium.org>

[modify] https://crrev.com/c2f9d1522e7a8df2aa4396f692c0f1cf93cf3e02/drm.c

Project Member

Comment 13 by sheriffbot@chromium.org, Nov 30 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-55 -Merge-Approved-55

Comment 15 by dbehr@chromium.org, Jan 20 2017

Status: Fixed (was: Started)

Comment 16 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 17 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 19 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment