taking a look now

Able to reproduce the issue on windows 7 as well using chrome version 56.0.2914.0

Regressed b/w previous canary(56.0.2913.0) and the latest(56.0.2914.0).

Last good build: 56.0.2913.0
First bad build: 56.0.2914.0

Changelog:
https://chromium.googlesource.com/chromium/src/+log/56.0.2913.0..56.0.2914.0?pretty=fuller&n=10000

Unable to repro. I just tried the unsigned win, win64, and win64-pgo with:

mini_installer.exe --chrome-sxs --verbose-logging

all three worked for me.

Could you provide more info on how you are running the installer and the exact nature of the failure? Could you attach %TEMP%\chrome_installer.log?

This is caused by my commit at r430728. I'll revert it and merge the revert to the branch.

Reverted on trunk at r430914.

Thanks for the quick turnaround and revert.

Just to update, seeing one installer related top crash on Windows canary(56.0.2914.0) with magic signature:install_static::`anonymous namespace'::AppendChromeInstallSubDirectory as well and probably rooted to r430728.

Link to the crashes:
====================
https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.ptype%3D%27Chrome%20Installer%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27install_static%3A%3A%60anonymous%20namespace%5C%27%3A%3AAppendChromeInstallSubDirectory%27%20AND%20product.name%3D%27Chrome%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D

Revert merged to 2914 at https://crrev.com/42f2553. Can anyone on the thread re-spin the Windows builds?

Yes, that crash is the one.

re-triggered Win builds on 2914 branch, will monitor and update the bug with details

Marking as fixed since the offending change has been reverted on trunk and branch.

It turns out that r430728 resulted in a test failure on the win_trunk continuous builder. I didn't get a nag email about the failure. If I had, I would have reverted this sooner. I'm enquiring with infra to find out why I didn't hear about the test failure.

grt@, thank you for the revert. Latest trunk#56.0.2914.1 is working fine w/o any issues.

Thank you Amit (ajha@) for finding this blocker issue.