New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663702 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression

Blocked on:
issue 664670



Sign in to add a comment

Offline icons on NTP tiles look off

Project Member Reported by mvanouwe...@chromium.org, Nov 9 2016

Issue description

The offline icons on the NTP tiles look off, see attached screenshot.
 
2016-11-09_11-45-15-UglyTilesDownloadIcon.png
126 KB View Download
Labels: M-56

Comment 2 by treib@chromium.org, Nov 9 2016

Labels: -M-56 M-55
Status: Available (was: Untriaged)
There was a recent email thread about this; IIUC it's already broken in M55.
The root cause is that these badges are reusing an Offline Pages icon, which was changed out from under us. We'll probably have to add a new asset.
Issue 663778 has been merged into this issue.
Thanks for looking into this Marc. 

Some additional spec details:
The correct icon can be found at go/icons, when searching for "offline pin". You can select the color (the blue offered there) and download pngs, or just take the svg and tint it "Google Blue" - #4285F4. I'm using a 2px stroke on the icon in my mocks - let's chat about whether that scales well.

WRT placement, it looks like this is correct in both the initial version and the regression. LMK if you have any questions.

Comment 5 by fi...@chromium.org, Nov 10 2016

Labels: -Type-Bug zine-triage zine-client-ux-v1 Type-Bug-Regression
Owner: ----
Who is going to take this? Would be great if we can get that merged back in M-55 until the next beta release next week. 

Comment 6 by fi...@chromium.org, Nov 10 2016

Labels: -zine-ux

Comment 7 by peconn@chromium.org, Nov 10 2016

(A black version of the offline pin already exists in the repo as offline_pin_black)

Comment 8 by treib@chromium.org, Nov 10 2016

Cc: ntp-dev+bugs@chromium.org
There was some way to "tint" an image in the UI, so this means we won't have to add a new icon :)

Comment 9 by peconn@chromium.org, Nov 10 2016

Owner: rachelis@chromium.org
Rachel - does this look good (I don't know where the mocks are, but this is a one line change).
2016-11-10_10-53-08-MostLikelyOfflineBadgeIdea.png
131 KB View Download

Comment 10 by fi...@chromium.org, Nov 10 2016

The mocks are in issue 663778. I think the only thing which is different is the border color. Yours is white and the mocks use the background color of the NTP.

Since your change is a one-liner, I'd recommend to merge that back to M-55 and then for M-56 we fix it like specified. 

Rachel, can you live with that?
How much more work would it be to address the stroke?
That turns it into a 2 line change :-).

It'll be slightly more tricky to add to M-55 (since they don't have the correct icon), but still fairly easy doable.
2016-11-10_14-51-42-TilesDownloadIconNew.png
129 KB View Download
//It'll be slightly more tricky to add to M-55 (since they don't have the correct icon), but still fairly easy doable.

Great, thanks! :)

Comment 15 by treib@chromium.org, Nov 11 2016

Cc: rachelis@chromium.org
Owner: peconn@chromium.org
Status: Started (was: Available)
Is this fixed? What is the merge status here?

Comment 17 by fi...@chromium.org, Nov 14 2016

Owner: treib@chromium.org
We're waiting until this change get's picked up by Canary. Then we'll merge.
If all goes well, we can merge it tomorrow before the next beta gets cut.
I think this is already in Canary. I see this in Canary 56.0.2919.0

Comment 19 by treib@chromium.org, Nov 14 2016

Cc: treib@chromium.org peconn@chromium.org
Owner: fgor...@chromium.org
Filip has graciously offered to handle this for M55. (Thanks!)
It's not a trivial merge, since the offline_pin_black item doesn't exist in M55 yet.

Comment 20 by fi...@chromium.org, Nov 14 2016

56.0.2919.0 wasn't available earlier today. :-)

I've verified that it works on Canary now. @Filip: You can go ahead and merge it. Do you think you can make it before Beta gets cut tomorrow? (~ 5pm PT)

Comment 21 by fi...@chromium.org, Nov 14 2016

Labels: -zine-triage zine-triaged
Blockedon: 664670
Patch that will be merged (most of it) is in review: https://codereview.chromium.org/2502763002/
Update: Patch has landed on trunk. Waiting for the buildbot to update the bugs.

There will be a fix required to NTP snippets:
* Currently it uses ImageView and alpha to color the icon to appropriate shade of gray.
* I recommend changing it to TintedImage, so that correct tint can be applied regardless of the icon's original color, just like Most visited sites badging works.
Project Member

Comment 25 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68cb4e748bb930a35ef2ae756dcb8d92db74263e

commit 68cb4e748bb930a35ef2ae756dcb8d92db74263e
Author: fgorski <fgorski@chromium.org>
Date: Tue Nov 15 19:04:10 2016

[Offline pages, NTP] Unifying offline_pin_round(_black) icon

Removes offline_pin_black icon and replaces its usage with
offline_pin_round.

This patch is meant to be merged in M55 (without the _black icon
removal, as it is not present there).

BUG= 664670 ,  663702 

Review-Url: https://codereview.chromium.org/2502763002
Cr-Commit-Position: refs/heads/master@{#432228}

[delete] https://crrev.com/a816bfc268006458526fb07e84ac1e03cd1ac03f/chrome/android/java/res/drawable-hdpi/offline_pin_black.png
[delete] https://crrev.com/a816bfc268006458526fb07e84ac1e03cd1ac03f/chrome/android/java/res/drawable-mdpi/offline_pin_black.png
[delete] https://crrev.com/a816bfc268006458526fb07e84ac1e03cd1ac03f/chrome/android/java/res/drawable-xhdpi/offline_pin_black.png
[delete] https://crrev.com/a816bfc268006458526fb07e84ac1e03cd1ac03f/chrome/android/java/res/drawable-xxhdpi/offline_pin_black.png
[delete] https://crrev.com/a816bfc268006458526fb07e84ac1e03cd1ac03f/chrome/android/java/res/drawable-xxxhdpi/offline_pin_black.png
[modify] https://crrev.com/68cb4e748bb930a35ef2ae756dcb8d92db74263e/chrome/android/java/res/layout/most_visited_item.xml
[modify] https://crrev.com/68cb4e748bb930a35ef2ae756dcb8d92db74263e/chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Labels: Merge-Request-55

Comment 27 by dimu@chromium.org, Nov 15 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 28 by bugdroid1@chromium.org, Nov 15 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfbee93f33fc4522da61cfa8182696803ad14f95

commit bfbee93f33fc4522da61cfa8182696803ad14f95
Author: Filip Gorski <fgorski@chromium.org>
Date: Tue Nov 15 23:23:50 2016

[Offline pages, NTP] Unifying offline_pin_round(_black) icon

Removes offline_pin_black icon and replaces its usage with
offline_pin_round.

This patch is meant to be merged in M55 (without the _black icon
removal, as it is not present there).

BUG= 664670 ,  663702 

Review-Url: https://codereview.chromium.org/2502763002
Cr-Commit-Position: refs/heads/master@{#432228}
(cherry picked from commit 68cb4e748bb930a35ef2ae756dcb8d92db74263e)

Review URL: https://codereview.chromium.org/2502133002 .

Cr-Commit-Position: refs/branch-heads/2883@{#581}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/bfbee93f33fc4522da61cfa8182696803ad14f95/chrome/android/java/res/layout/most_visited_item.xml

Labels: -M-55 M-56
Owner: treib@chromium.org
Removing M55 as this has been merged.

Marc and Peter, please take a look at comment #24 and solve it before M56 branch.
You can probably track it as a separate bug.

Comment 30 by treib@chromium.org, Nov 16 2016

Owner: peconn@chromium.org
Thanks Filip!
Over to Peter for the alpha -> TintedImage fix. But I don't think we strictly need that for M56?
I'd recommend it if you are shipping snippets in M56. The icon is a little lighter now. Perhaps a fix as simple as removing alpha from the image could do for M56.

Comment 32 by treib@chromium.org, Nov 17 2016

Status: Fixed (was: Started)
On second thought: The badge on suggestions cards is a different thing; filed bug 666288 for that.

Sign in to add a comment