Issue metadata
Sign in to add a comment
|
Offline icons on NTP tiles look off |
||||||||||||||||||||||
Issue descriptionThe offline icons on the NTP tiles look off, see attached screenshot.
,
Nov 9 2016
There was a recent email thread about this; IIUC it's already broken in M55. The root cause is that these badges are reusing an Offline Pages icon, which was changed out from under us. We'll probably have to add a new asset.
,
Nov 9 2016
Issue 663778 has been merged into this issue.
,
Nov 9 2016
Thanks for looking into this Marc. Some additional spec details: The correct icon can be found at go/icons, when searching for "offline pin". You can select the color (the blue offered there) and download pngs, or just take the svg and tint it "Google Blue" - #4285F4. I'm using a 2px stroke on the icon in my mocks - let's chat about whether that scales well. WRT placement, it looks like this is correct in both the initial version and the regression. LMK if you have any questions.
,
Nov 10 2016
Who is going to take this? Would be great if we can get that merged back in M-55 until the next beta release next week.
,
Nov 10 2016
,
Nov 10 2016
(A black version of the offline pin already exists in the repo as offline_pin_black)
,
Nov 10 2016
There was some way to "tint" an image in the UI, so this means we won't have to add a new icon :)
,
Nov 10 2016
Rachel - does this look good (I don't know where the mocks are, but this is a one line change).
,
Nov 10 2016
The mocks are in issue 663778. I think the only thing which is different is the border color. Yours is white and the mocks use the background color of the NTP. Since your change is a one-liner, I'd recommend to merge that back to M-55 and then for M-56 we fix it like specified. Rachel, can you live with that?
,
Nov 10 2016
How much more work would it be to address the stroke?
,
Nov 10 2016
That turns it into a 2 line change :-). It'll be slightly more tricky to add to M-55 (since they don't have the correct icon), but still fairly easy doable.
,
Nov 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a74fcfbafb42fff45822fe206ba291bc8533701 commit 1a74fcfbafb42fff45822fe206ba291bc8533701 Author: peconn <peconn@chromium.org> Date: Thu Nov 10 16:02:30 2016 [NTP] Correct the Offline Badge shown on tiles. BUG= 663702 Review-Url: https://codereview.chromium.org/2492463004 Cr-Commit-Position: refs/heads/master@{#431266} [modify] https://crrev.com/1a74fcfbafb42fff45822fe206ba291bc8533701/chrome/android/java/res/drawable/offline_badge_background.xml [modify] https://crrev.com/1a74fcfbafb42fff45822fe206ba291bc8533701/chrome/android/java/res/layout/most_visited_item.xml
,
Nov 10 2016
//It'll be slightly more tricky to add to M-55 (since they don't have the correct icon), but still fairly easy doable. Great, thanks! :)
,
Nov 11 2016
,
Nov 14 2016
Is this fixed? What is the merge status here?
,
Nov 14 2016
We're waiting until this change get's picked up by Canary. Then we'll merge. If all goes well, we can merge it tomorrow before the next beta gets cut.
,
Nov 14 2016
I think this is already in Canary. I see this in Canary 56.0.2919.0
,
Nov 14 2016
Filip has graciously offered to handle this for M55. (Thanks!) It's not a trivial merge, since the offline_pin_black item doesn't exist in M55 yet.
,
Nov 14 2016
56.0.2919.0 wasn't available earlier today. :-) I've verified that it works on Canary now. @Filip: You can go ahead and merge it. Do you think you can make it before Beta gets cut tomorrow? (~ 5pm PT)
,
Nov 14 2016
,
Nov 14 2016
,
Nov 14 2016
Patch that will be merged (most of it) is in review: https://codereview.chromium.org/2502763002/
,
Nov 15 2016
Update: Patch has landed on trunk. Waiting for the buildbot to update the bugs. There will be a fix required to NTP snippets: * Currently it uses ImageView and alpha to color the icon to appropriate shade of gray. * I recommend changing it to TintedImage, so that correct tint can be applied regardless of the icon's original color, just like Most visited sites badging works.
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68cb4e748bb930a35ef2ae756dcb8d92db74263e commit 68cb4e748bb930a35ef2ae756dcb8d92db74263e Author: fgorski <fgorski@chromium.org> Date: Tue Nov 15 19:04:10 2016 [Offline pages, NTP] Unifying offline_pin_round(_black) icon Removes offline_pin_black icon and replaces its usage with offline_pin_round. This patch is meant to be merged in M55 (without the _black icon removal, as it is not present there). BUG= 664670 , 663702 Review-Url: https://codereview.chromium.org/2502763002 Cr-Commit-Position: refs/heads/master@{#432228} [delete] https://crrev.com/a816bfc268006458526fb07e84ac1e03cd1ac03f/chrome/android/java/res/drawable-hdpi/offline_pin_black.png [delete] https://crrev.com/a816bfc268006458526fb07e84ac1e03cd1ac03f/chrome/android/java/res/drawable-mdpi/offline_pin_black.png [delete] https://crrev.com/a816bfc268006458526fb07e84ac1e03cd1ac03f/chrome/android/java/res/drawable-xhdpi/offline_pin_black.png [delete] https://crrev.com/a816bfc268006458526fb07e84ac1e03cd1ac03f/chrome/android/java/res/drawable-xxhdpi/offline_pin_black.png [delete] https://crrev.com/a816bfc268006458526fb07e84ac1e03cd1ac03f/chrome/android/java/res/drawable-xxxhdpi/offline_pin_black.png [modify] https://crrev.com/68cb4e748bb930a35ef2ae756dcb8d92db74263e/chrome/android/java/res/layout/most_visited_item.xml [modify] https://crrev.com/68cb4e748bb930a35ef2ae756dcb8d92db74263e/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
,
Nov 15 2016
,
Nov 15 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfbee93f33fc4522da61cfa8182696803ad14f95 commit bfbee93f33fc4522da61cfa8182696803ad14f95 Author: Filip Gorski <fgorski@chromium.org> Date: Tue Nov 15 23:23:50 2016 [Offline pages, NTP] Unifying offline_pin_round(_black) icon Removes offline_pin_black icon and replaces its usage with offline_pin_round. This patch is meant to be merged in M55 (without the _black icon removal, as it is not present there). BUG= 664670 , 663702 Review-Url: https://codereview.chromium.org/2502763002 Cr-Commit-Position: refs/heads/master@{#432228} (cherry picked from commit 68cb4e748bb930a35ef2ae756dcb8d92db74263e) Review URL: https://codereview.chromium.org/2502133002 . Cr-Commit-Position: refs/branch-heads/2883@{#581} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/bfbee93f33fc4522da61cfa8182696803ad14f95/chrome/android/java/res/layout/most_visited_item.xml
,
Nov 15 2016
Removing M55 as this has been merged. Marc and Peter, please take a look at comment #24 and solve it before M56 branch. You can probably track it as a separate bug.
,
Nov 16 2016
Thanks Filip! Over to Peter for the alpha -> TintedImage fix. But I don't think we strictly need that for M56?
,
Nov 16 2016
I'd recommend it if you are shipping snippets in M56. The icon is a little lighter now. Perhaps a fix as simple as removing alpha from the image could do for M56.
,
Nov 17 2016
On second thought: The badge on suggestions cards is a different thing; filed bug 666288 for that. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mvanouwe...@chromium.org
, Nov 9 2016