Issue metadata
Sign in to add a comment
|
Regression: In error page, sad face blurs out on changing zoom level to 110%.
Reported by
vvishwak...@etouch.net,
Nov 9 2016
|
||||||||||||||||||||||
Issue descriptionVersion: 56.0.2914.0 (Official Build)a081fcfbc7471a6681142d49491b82f7b8402851-refs/heads/master@{#430837} (32/64-bit) OS: Windows (7,8,10), Mac (10.10.5, 10.11.4), Linux (14.04 LTS) What steps will reproduce the problem? 1) Launch chrome, go to chrome://.. and zoom the page to 110%. 2) Observe the sad face after zooming the page. Sad face is seen blur on zooming the page. Sad face should not be blur on zooming the page. This is a Regression issue broken in M-56, will soon update other info Manual bisect: Good build: 56.0.2900.0 Bad build: 56.0.2902.0 Note: Issue is not seen on Windows and Linux OS.
,
Nov 9 2016
Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.
,
Nov 9 2016
So, somewhat counterintuatively, the image here is being downscaled. When you go to 110%, the page switches to its 2x asset and downscales that by 0.55x. It appears that in this case, the GPU raster downscale is slightly blurrier than the SW raster downscale. Not sure that this is a huge issue - my guess is that there are some scales / images where GPU will look better (due to performing full trilinear filtering) and some cases where SW may look better. Cases where we really want to maintain sharp edges should probably be using SVG.
,
Nov 9 2016
For an example of where SW raster's sharpness ends up looking less good, consider the attached image. The top version uses the sharper SW raster downscaling, which leads to aliasing in the cat's whiskers. The smoother GPU raster downscaling does not show this issue. I'm not sure that we'll be able to be ideal in all situations, and what we have might be fine. bsalomon@, wdyt?
,
Nov 9 2016
I believe the sw is using bilinear filtering not trilinear. This is certainly possible on the GPU but I think in general will look worse. Depending on the GPU we could bias the LOD lookup towards being sharper if we think that would look better. However, I tend to agree with the comment in #3 that if the content is a vector graphic then it would be better to use canvas or svg to draw at display resolution rather than relying on image filtering to preserve sharpness.
,
Nov 14 2016
So is this a WontFix? I assume we don't want to use nearest neighbor, as that tends to look pretty awful. We could alternatively use nearest neighbor and try to adjust image size so it's always upscaled only to integer multiples of its original size, and use nearest neighbor scaling (Does CSS allow that, or woudl we have to switch to a canvas or something?) though that does seem more than a little weird.
,
Nov 14 2016
I think that this is either WontFix, or we should adjust Skia's LOD bias to be sharper. Sharpening would have the downside of introducing more aliasing into images. The image in question happens to look better with a sharper downscale, but other types of content (photos) likely won't (see #4). My preference is to wontfix, and if we want to address this icon on the content side, we could use an SVG or other vector format. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by hdodda@chromium.org
, Nov 9 2016Labels: -hasbisect hasbisect-per-revision
Owner: ericrk@chromium.org
Status: Assigned (was: Unconfirmed)