Issue metadata
Sign in to add a comment
|
"org.chromium.chrome.browser.permissions.GeolocationTest#testGeolocationPersistenceOffAllowedDialog" is flaky |
||||||||||||||||||||||
Issue description"org.chromium.chrome.browser.permissions.GeolocationTest#testGeolocationPersistenceOffAllowedDialog" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybQsSBUZsYWtlImJvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIucGVybWlzc2lvbnMuR2VvbG9jYXRpb25UZXN0I3Rlc3RHZW9sb2NhdGlvblBlcnNpc3RlbmNlT2ZmQWxsb3dlZERpYWxvZww. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Nov 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3e6a489c9f48752727323003dff1704e8f94211 commit a3e6a489c9f48752727323003dff1704e8f94211 Author: vabr <vabr@chromium.org> Date: Wed Nov 09 14:26:35 2016 Disable flaky GeolocationTest#testGeolocationPersistenceOffAllowedDialogo TBR=dominickn@chromium.org,tedchoc@chromium.org BUG= 663677 Review-Url: https://codereview.chromium.org/2483073005 Cr-Commit-Position: refs/heads/master@{#430927} [modify] https://crrev.com/a3e6a489c9f48752727323003dff1704e8f94211/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java
,
Nov 29 2016
Hey Dom - could you ptal at this test failure? Thanks!
,
Nov 29 2016
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5 commit c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5 Author: dominickn <dominickn@chromium.org> Date: Tue Nov 29 20:41:53 2016 Deflake permission dialog + persistence toggle tests on Android. These tests would flake through timing out while waiting for a switch to be toggled. The toggle was triggered through a synthetic touch event sent to the switch view. Observing the flake would reveal that the switch stayed in its original position after the touch event was sent, so the hypothesis is that the touch event was sent prior to the view being ready to respond to it. This CL deflakes the tests by replacing the touch event for triggering the toggle with an explicit toggle() call on the SwitchCompat object. This no longer simulates the user input, but the tests should now reliably pass. This CL also corrects the arguments used for MediaTest#testCombinedPersistenceOffDialog to match those of MediaTest#testMicrophonePersistenceOffDialog. BUG= 662294 , 663677 , 668700 Review-Url: https://codereview.chromium.org/2538603002 Cr-Commit-Position: refs/heads/master@{#435074} [modify] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java [modify] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java [modify] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestCaseBase.java
,
Nov 30 2016
Successfully deflaked: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=geolocationtest%23testGeolocationWatchPersistenceOffAllowedDialog |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vabr@chromium.org
, Nov 9 2016Labels: -Sheriff-Chromium OS-Android