New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663669 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 640685



Sign in to add a comment

Inconsistent keyboard focus style in quick view buttons

Project Member Reported by yamaguchi@chromium.org, Nov 9 2016

Issue description

Chrome Version: Chromium: 56.0.2915.0

Steps To Reproduce:
(1) Open Files app.
(2) Choose an image file.
(3) Hit space key to enter the quick view mode.
(4) Hit [TAB] key until the "File information" button (circle icon with "i" in it) is focused.

Expected Result:
The focus on File Information button is shown in a consistent style with other buttons like the "open" button.
(white, thick rounded square)

Actual Result:
The focus is expressed by a different style.
(blue, thin rounded square, which looks like the default style of files-icon-button)


How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always.

What is the impact to the user, and is there a workaround? If so, what is
it?
This bug just affects the appearance of the UI.

 
Status: Assigned (was: Unconfirmed)
Blocking: 640685

Comment 3 by oka@chromium.org, Jan 11 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0959faf15de830455fa90014920adec9c880bc2

commit e0959faf15de830455fa90014920adec9c880bc2
Author: oka <oka@chromium.org>
Date: Thu Jan 12 06:26:41 2017

Fix inconsistent keyboard focus style in quick view buttons.

Updated the open file button's outline to be consistent with the
outline of metadata box toggle button.

TEST=manually.
BUG= 663669 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2623413002
Cr-Commit-Position: refs/heads/master@{#443169}

[modify] https://crrev.com/e0959faf15de830455fa90014920adec9c880bc2/ui/file_manager/file_manager/foreground/elements/files_quick_view.css

Comment 5 by oka@chromium.org, Jan 12 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 9202.0.0, 57.0.2984.0

Sign in to add a comment