New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 663661 link

Starred by 2 users
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Nov 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
michae...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : In md-settings, ‘Page zoom’ drop down list appears blank after changing the ‘page zoom’ level to 175%.

Reported by yfulgaon...@etouch.net, Nov 9 2016 
Chrome Version : 56.0.2914.0 (Official Build)a081fcfbc7471a6681142d49491b82f7b8402851-refs/heads/master@{#430837} 32/64-bit
OS : Mac(10.10.5, 10.11.4), Windows (7,8,8.1,10), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch Chrome and navigate to chrome://md-settings page.
2. Go to ‘Appearance’ section and change the ‘page zoom’ level to 175%.
3. Now reload the page and observe the ‘Page zoom’ drop down list

Actual : ‘Page zoom’ drop down list appears blank after changing the ‘page zoom’ level to 175%.
Expected : ‘Page zoom’ drop down list should not be blank after changing the ‘page zoom’ level to 175%.

This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update bisect info.
Good build : 56.0.2888.0
Bad build : 56.0.2891.0

Note : Issue is also seen after changing the ‘Page zoom’ level to 500% in chrome://md-settings.
Actual_md-settings.mov
4.8 MB Download
Expec_md-settings.mov
4.8 MB Download

Comment 1 by msrchandra@chromium.org, Nov 9 2016

Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2888.0 (Revision: 424625).
Bad build: 56.0.2891.0 (Revision: 425529).

You are probably looking for a change made after 425518 (known good), but no later than 425519 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/c53bfdf1cab780b6d732954a26d0a977d418cf48..7577ff2509a7a5d91ec319f12a42dd1acdb1a41f

@dpapad -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.

Comment 2 by dpa...@chromium.org, Nov 9 2016

Owner: dbeam@chromium.org
@dbeam: This sounds similar to what  crbug.com/655742  already fixed. Could you take a look (are we still having ghost zoom levels, or rounding errors)?

Comment 3 by dbeam@chromium.org, Nov 10 2016

Cc: michae...@chromium.org
Status: Started (was: Assigned)
yep, 175% is coming in at like 174.99999 and .value = '174.9999' is failing

this is where michaelpg@ gets to say "i told you so".

i have a better (not amazing) fix.  but general zoom handling in chrome isn't amazing either.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0e9385ba796fd29e1f0f11126a18e173364c864

commit e0e9385ba796fd29e1f0f11126a18e173364c864
Author: dbeam <dbeam@chromium.org>
Date: Thu Nov 10 02:33:44 2016

MD Settings: [further] robustify default zoom level handling

R=dpapad@chromium.org
BUG= 663661 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2488113002
Cr-Commit-Position: refs/heads/master@{#431149}

[modify] https://crrev.com/e0e9385ba796fd29e1f0f11126a18e173364c864/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/e0e9385ba796fd29e1f0f11126a18e173364c864/chrome/browser/resources/settings/appearance_page/appearance_page.js
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0e9385ba796fd29e1f0f11126a18e173364c864

commit e0e9385ba796fd29e1f0f11126a18e173364c864
Author: dbeam <dbeam@chromium.org>
Date: Thu Nov 10 02:33:44 2016

MD Settings: [further] robustify default zoom level handling

R=dpapad@chromium.org
BUG= 663661 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2488113002
Cr-Commit-Position: refs/heads/master@{#431149}

[modify] https://crrev.com/e0e9385ba796fd29e1f0f11126a18e173364c864/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/e0e9385ba796fd29e1f0f11126a18e173364c864/chrome/browser/resources/settings/appearance_page/appearance_page.js

Comment 6 by dbeam@chromium.org, Nov 10 2016

Status: Fixed (was: Started)
►

Sign in to add a comment