New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663636 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 640685



Sign in to add a comment

"File information" toolbar button in quick view not accessible by keyboard for some file types

Project Member Reported by yamaguchi@chromium.org, Nov 9 2016

Issue description

Chrome Version: Chromium: 56.0.2915.0

Steps To Reproduce:
(1) Open Files app.
(2) Choose a file which cannot be previewed by quick view (e.g. a text file)
(3) Hit space key to enter the quick view mode. It will say "preview not available" for the file.
(4) Hit [TAB] key several times.

Expected Result:
File Information button (circle icon with "i" in it) can be focused.

Actual Result:
The button never gets focus.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always.

What is the impact to the user, and is there a workaround? If so, what is
it?
User will not be able to show/hide the file information pane using keyboard.

Please provide any additional information below. Attach a screen shot or
log if possible.

The button can get focus when previewing an image file (when it has "open" button next to it.)

 
Description: Show this description
Status: Assigned (was: Unconfirmed)
Blocking: 640685

Comment 4 by oka@chromium.org, Dec 9 2016

Status: Started (was: Assigned)

Comment 5 by oka@chromium.org, Dec 16 2016

Cc: yamaguchi@chromium.org weifangsun@chromium.org fukino@chromium.org
This might be related.
https://bugs.chromium.org/p/chromium/issues/detail?id=459858

Comment 6 by oka@chromium.org, Dec 21 2016

Strangely if we swap two buttons this issue doesn't happen.
I'll create reduction in next week.

Comment 7 by oka@chromium.org, Dec 27 2016

Cc: michae...@chromium.org
Looks like it's iron-overlay-behavior's bug. Updating it's version to 1.10, the issue is fixed.

michaelpg@, is there a plan to update iron-overlay-behavior?

I'll investigate possible workaround tomorrow.

Comment 8 by oka@chromium.org, Dec 27 2016

The fix for iron-overlay-behavior is https://github.com/PolymerElements/iron-overlay-behavior/pull/200, which is available with >=1.10.

Comment 9 by oka@chromium.org, Jan 8 2017

michaelpg@ Friendly ping?
How can we update iron-overlay-behavior's version?

Comment 10 by oka@chromium.org, Jan 11 2017

Cc: dbeam@chromium.org
Let me add dbeam@ to CC. How can we update iron-overlay-behavior's version?

Comment 11 by dbeam@chromium.org, Jan 11 2017

fine by me, it's not used by settings or history or downloads much any more

we've moved from:
<paper-dialog> -> <dialog is="cr-dialog">
<paper-dropdown-menu> -> <select>
<iron-dropdown> -> <dialog is="cr-action-menu">

https://cs.chromium.org/search/?q=%5C%22iron-overlay-behavior%5C%22+file:%5Esrc/third_party/polymer/v1_0/&sq=package:chromium&type=cs

Comment 12 by oka@chromium.org, Jan 12 2017

Dan, I don't know how to update the version. Could you explain how to do that? 
Do we use bower and copy/paste components/iron-overlay-behaviour into components-chromium, maybe?
Or, I'd appreciate it if you can do that for me.
Thanks.

Comment 13 by dbeam@chromium.org, Jan 13 2017

change the version in third_party/polymer/v1_0/bower.json and re-run third_party/polymer/v1_0/reproduce.sh

Comment 14 by oka@chromium.org, Jan 16 2017

Thank you Dan. I updated the version and sent CL https://codereview.chromium.org/2633003003/.
reproduce.sh updated the header of all the elements from 2016 to 2017, but I guess it's WAI.

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26

commit 3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26
Author: oka <oka@chromium.org>
Date: Wed Jan 18 09:34:19 2017

Update iron-overlay-behavior to version 1.10.2.

Files App's quick view is suffered from the bug
https://github.com/PolymerElements/iron-overlay-behavior/pull/200,
and focus doesn't move inside files-quick-view element if a button
inside it is hidden.
Updating iron-overlay-behavior fixes the issue.

This CL was created by the following steps.
1. Change the version in third_party/polymer/v1_0/bower.json
2. Run third_party/polymer/v1_0/reproduce.sh
3. tools/polymer/polymer_grdp_to_txt.py ui/webui/resources/polymer_resources.grdp > polymer.txt
vim polymer.txt # add iron-overlay-behavior/iron-focusables-helper{-extracted.js,.html}
tools/polymer/txt_to_polymer_grdp.py polymer.txt > ui/webui/resources/polymer_resources.grdp

BUG= 663636 
TEST=git cl try. third_party/closure_compiler/run_compiler.
    The issue mentioned above is fixed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2633003003
Cr-Commit-Position: refs/heads/master@{#444313}

[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/chrome/browser/resources/md_history/lazy_load.crisper.js
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/chrome/browser/resources/md_history/lazy_load.vulcanized.html
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/app-layout/app-box/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/app-layout/app-drawer-layout/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/app-layout/app-drawer/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/app-layout/app-header-layout/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/app-layout/app-header/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/app-layout/app-scrollpos-control/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/app-layout/app-toolbar/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/app-layout/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/app-layout/helpers/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/font-roboto/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-a11y-announcer/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-a11y-keys/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-behaviors/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-collapse/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-fit-behavior/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-flex-layout/classes/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-flex-layout/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-form-element-behavior/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-icon/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-icons/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-iconset-svg/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-input/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-list/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-location/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-media-query/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-menu-behavior/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-meta/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/compiled_resources2.gyp
[add] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-focusables-helper-extracted.js
[add] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-focusables-helper.html
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-behavior-extracted.js
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-behavior.html
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-pages/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-range-behavior/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-resizable-behavior/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-scroll-target-behavior/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-scroll-threshold/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-selector/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-test-helpers/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/iron-validatable-behavior/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/neon-animation/animations/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/neon-animation/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-behaviors/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-button/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-checkbox/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-dialog/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-drawer-panel/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-fab/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-header-panel/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-icon-button/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button-light.html
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-input/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-item/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-listbox/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-material/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-menu-button/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-menu/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-progress/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-radio-button/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-radio-group/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-ripple/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-slider/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-spinner/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-styles/classes/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-styles/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-tabs/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-toggle-button/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-toolbar/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components-chromium/paper-tooltip/compiled_resources2.gyp
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/3666a6adbabb30d6d4f2fc53ebf7817b22ad0f26/ui/webui/resources/polymer_resources.grdp

Comment 16 by oka@chromium.org, Jan 19 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Test version 9202.4.0, 57.0.2987.8

Sign in to add a comment