Issue 663631 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	drinkcat@chromium.org
Closed:	Nov 2016
Cc:	█ vpalatin@chromium.org █ rspangler@chromium.org █ mschilder@chromium.org nsanders@chromium.org adurbin@chromium.org
Components:	OS>Firmware>EC
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

EC: Add support for exponent 3 RSA keys

Project Member Reported by drinkcat@chromium.org, Nov 9 2016

Issue description

EC codebase normally uses exponent F4/65537 for its RSA keys, which is much slower than exponent 3 (4-5 times slower according to simple experiments).

Let's add support for exponent 3, for cases where boot-time verification time is critical.

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/f44bc369824ee4c14c5d0987673e27e6510843bc

commit f44bc369824ee4c14c5d0987673e27e6510843bc
Author: Nicolas Boichat <drinkcat@google.com>
Date: Wed Nov 09 03:22:01 2016

test/rsa: Add test for RSA signature checking

This tests RSA 2048 with public exponent F4 (65537).

BRANCH=none
BUG= chromium:663631 
TEST=make run-rsa3

Change-Id: I195a349bb9a862606971054adc9ac3b56a817fe7
Reviewed-on: https://chromium-review.googlesource.com/408129
Commit-Ready: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>

[add] https://crrev.com/f44bc369824ee4c14c5d0987673e27e6510843bc/test/rsa.c
[add] https://crrev.com/f44bc369824ee4c14c5d0987673e27e6510843bc/test/rsa2048-F4.h
[modify] https://crrev.com/f44bc369824ee4c14c5d0987673e27e6510843bc/test/test_config.h
[modify] https://crrev.com/f44bc369824ee4c14c5d0987673e27e6510843bc/test/build.mk
[add] https://crrev.com/f44bc369824ee4c14c5d0987673e27e6510843bc/test/rsa2048-F4.pem
[add] https://crrev.com/f44bc369824ee4c14c5d0987673e27e6510843bc/test/rsa.tasklist

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/ef0f355e476b02dc74d99c25881d77488798e9bc

commit ef0f355e476b02dc74d99c25881d77488798e9bc
Author: Nicolas Boichat <drinkcat@google.com>
Date: Mon Nov 07 07:17:53 2016

common/rsa: Add support for exponent 3 RSA keys

These keys are much quicker to verify (259ms to 51ms on a -M0 at
48 Mhz), so they can be used when timing is critical and
verification needs to be performed on the board.

BRANCH=none
BUG= chromium:663631 
TEST=make buildall -j && make run-rsa
TEST=make run-rsa3 (next commit)

Change-Id: I0da4b3e21543bb6f7b18e8b6ddc5e153046a61b8
Reviewed-on: https://chromium-review.googlesource.com/408006
Commit-Ready: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>

[modify] https://crrev.com/ef0f355e476b02dc74d99c25881d77488798e9bc/common/rsa.c
[modify] https://crrev.com/ef0f355e476b02dc74d99c25881d77488798e9bc/include/config.h

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/d7178e9b5faddabbfc5cdf2223bd5b865c58338e

commit d7178e9b5faddabbfc5cdf2223bd5b865c58338e
Author: Nicolas Boichat <drinkcat@google.com>
Date: Wed Nov 09 06:06:01 2016

test/rsa: Add test for RSA with public exponent 3

This tests RSA 2048 with public exponent 3.

BRANCH=none
BUG= chromium:663631 
TEST=make run-rsa3

Change-Id: I979ad4a23de6baba63aba037d2713b74fed4737f
Reviewed-on: https://chromium-review.googlesource.com/408130
Commit-Ready: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>

[modify] https://crrev.com/d7178e9b5faddabbfc5cdf2223bd5b865c58338e/test/rsa.c
[add] https://crrev.com/d7178e9b5faddabbfc5cdf2223bd5b865c58338e/test/rsa3.tasklist
[modify] https://crrev.com/d7178e9b5faddabbfc5cdf2223bd5b865c58338e/test/build.mk
[add] https://crrev.com/d7178e9b5faddabbfc5cdf2223bd5b865c58338e/test/rsa2048-3.h
[modify] https://crrev.com/d7178e9b5faddabbfc5cdf2223bd5b865c58338e/test/test_config.h
[add] https://crrev.com/d7178e9b5faddabbfc5cdf2223bd5b865c58338e/test/rsa2048-3.pem