New issue
Advanced search Search tips

Issue 663624 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Migrate WorkerThread::ForceTerminationTask to WebTaskRunner::postDelayedCancellableTask from CancellableTaskFactory

Project Member Reported by nhiroki@chromium.org, Nov 9 2016

Issue description

WorkerThread::ForceTerminationTask is currently implemented with CancellableTaskFactory that is deprecated in favor of WebTaskRunner::post(Delayed)CancellableTask.
 
Owner: nhiroki@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb4c1fe6ad37005d9818c65a42728ac7179bf499

commit fb4c1fe6ad37005d9818c65a42728ac7179bf499
Author: nhiroki <nhiroki@chromium.org>
Date: Fri Nov 11 14:35:21 2016

Worker: Replace CancellableTaskFactory with postDelayedCancellableTask

Before this CL, WorkerThread::ForceTerminationTask is implemented with
CancellableTaskFactory that is deprecated in favor of
WebTaskRunner::post(Delayed)CancellableTask.

This CL removes ForceTerminationTask/CancellableTaskFactory, and instead
implements the same functionality with postDelayedCancellableTask.

BUG= 663624 

Review-Url: https://codereview.chromium.org/2490113002
Cr-Commit-Position: refs/heads/master@{#431559}

[modify] https://crrev.com/fb4c1fe6ad37005d9818c65a42728ac7179bf499/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/fb4c1fe6ad37005d9818c65a42728ac7179bf499/third_party/WebKit/Source/core/workers/WorkerThread.h
[modify] https://crrev.com/fb4c1fe6ad37005d9818c65a42728ac7179bf499/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment