New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663617 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 660994



Sign in to add a comment

DesktopWindowTreeHostMus needs to implement window stacking

Project Member Reported by sky@chromium.org, Nov 9 2016

Issue description

StackAbove and StackAtTop need to call through to mus.
 

Comment 2 by e...@chromium.org, Jan 13 2017

Owner: e...@chromium.org
Status: Assigned (was: Untriaged)
Taking this.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a77d1f27b7d151775ba412bd522344e060736d02

commit a77d1f27b7d151775ba412bd522344e060736d02
Author: erg <erg@chromium.org>
Date: Fri Jan 20 23:42:29 2017

aura-mus: Implement DesktopWindowTreeHostMus::StackAtTop().

Adds API to the window server so that a client can request that one of
their windows gets stacked on top of everything else.

BUG= 663617 

Review-Url: https://codereview.chromium.org/2633233003
Cr-Commit-Position: refs/heads/master@{#445211}

[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/services/ui/public/cpp/tests/test_window_tree.cc
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/services/ui/public/cpp/tests/test_window_tree.h
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/services/ui/ws/access_policy.h
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/services/ui/ws/access_policy_delegate.h
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/services/ui/ws/default_access_policy.cc
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/services/ui/ws/default_access_policy.h
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/services/ui/ws/window_manager_access_policy.cc
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/services/ui/ws/window_manager_access_policy.h
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/services/ui/ws/window_tree.cc
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/services/ui/ws/window_tree.h
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/ui/aura/BUILD.gn
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/ui/aura/mus/window_tree_client.h
[add] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/ui/aura/mus/window_tree_client_test_observer.h
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/ui/aura/mus/window_tree_host_mus.cc
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/ui/aura/mus/window_tree_host_mus.h
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/ui/aura/mus/window_tree_host_mus_delegate.h
[add] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/ui/aura/test/mus/change_completion_waiter.cc
[add] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/ui/aura/test/mus/change_completion_waiter.h
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/ui/aura/test/mus/test_window_tree.cc
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/ui/aura/test/mus/test_window_tree.h
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/a77d1f27b7d151775ba412bd522344e060736d02/ui/views/mus/desktop_window_tree_host_mus_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc615bd3f80accc95a7ff9da81e80a6420479bb0

commit bc615bd3f80accc95a7ff9da81e80a6420479bb0
Author: erg <erg@chromium.org>
Date: Thu Jan 26 19:55:15 2017

aura-mus: Implement DesktopWindowTreeHostMus::StackAbove().

Adds API to the window server and the window manager so that a client
can request that one of their roots owned by the window manager can be
placed above another one of their roots owned by the window manager.

BUG= 663617 

Review-Url: https://codereview.chromium.org/2655463009
Cr-Commit-Position: refs/heads/master@{#446409}

[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/services/ui/ws/access_policy.h
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/services/ui/ws/default_access_policy.cc
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/services/ui/ws/default_access_policy.h
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/services/ui/ws/test_utils.cc
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/services/ui/ws/test_utils.h
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/services/ui/ws/window_manager_access_policy.cc
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/services/ui/ws/window_manager_access_policy.h
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/services/ui/ws/window_tree.cc
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/services/ui/ws/window_tree.h
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/ui/aura/mus/window_tree_host_mus.cc
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/ui/aura/mus/window_tree_host_mus.h
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/ui/aura/mus/window_tree_host_mus_delegate.h
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/ui/aura/test/mus/test_window_tree.cc
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/ui/aura/test/mus/test_window_tree.h
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/bc615bd3f80accc95a7ff9da81e80a6420479bb0/ui/views/mus/desktop_window_tree_host_mus_unittest.cc

Comment 6 by e...@chromium.org, Jan 26 2017

Status: Fixed (was: Assigned)

Comment 7 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment