New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663614 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security



Sign in to add a comment

Stack-buffer-overflow in Hunspell::suggest

Project Member Reported by ClusterFuzz, Nov 9 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6720769892810752

Fuzzer: libfuzzer_hunspell_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Stack-buffer-overflow WRITE {*}
Crash Address: 0x7fecb5e69a70
Crash State:
  Hunspell::suggest
  _start
  Hunspell::suggest
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=414841:414879

Minimized Testcase (0.09 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96bOvQbTU1EcOoAu377ZA5ne-Emwb3I_AUB-TE0IwmHx2S80eeFU5B1umSiFjFwLgkURxNzR3WGjkvE2__5X10Rac3Mhcb8QMyCNEFW7gx8MrhiQtla-80No9s-u_1EH-IfTnCLrhGRHT7B4EfyXQGQWXjEQg?testcase_id=6720769892810752

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: rouslan@chromium.org
Components: UI>Browser>Spellcheck
Owner: groby@chromium.org
Status: Assigned (was: Untriaged)
Adding owners of third_party/hunspell, mind giving this a look?
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 9 2016

Labels: M-55
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 9 2016

Labels: ReleaseBlock-Stable
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 9 2016

Labels: Pri-1
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 10 2016

Labels: M-55

Comment 6 by gov...@chromium.org, Nov 14 2016

**** Bulk edit -  please ignore if not applicable ****


A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Also due to Thanksgiving holidays in US, please make sure fix is ready and merged to M55 latest by 5:00 PM PT Friday, 11/18/16 (sooner the better).

Comment 7 by groby@chromium.org, Nov 16 2016

Please see  bug #641841 , specifically comment 7[1], on why this should be neither RBS nor P1. Short version:

* Very hard to trigger, requires complicated user interaction.
* hunspell is happening in render sandbox to address exactly these issues
* We will lose this fix when we roll DEPS. We can't roll DEPS, because upstream is bad

I would *recommend* removing RBS and bumping to P2. If security concerns outweigh my reasoning above, the only viable avenue is shutting down spellcheck on Windows/Linux/CrOS.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=641841#c7

Labels: -Pri-1 -M-55 -Security_Severity-High -ReleaseBlock-Stable Security_Severity-Medium M-56 Pri-2
Thanks for the updating.  Moving to 56 and downgrading.  What's the best way to report this upstream, so we do get a fix once they've got their act together?

Comment 9 by groby@chromium.org, Nov 16 2016

Cc: k...@chromium.org
Since we're seriously out-of-date with respect to upstream, I suspect they'll ignore it, but https://github.com/hunspell/hunspell is the upstream repo if you want to try anyways.

And we can't catch up with upstream because they still haven't fixed https://github.com/hunspell/hunspell/issues/402 and https://github.com/hunspell/hunspell/issues/403, which breaks hu-HU spelling (and our existing test coverage)


Labels: -Security_Severity-Medium Security_Severity-Low
reducing security as per #7.
Project Member

Comment 11 by ClusterFuzz, Dec 14 2016

ClusterFuzz has detected this issue as fixed in range 438170:438219.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6720769892810752

Fuzzer: libfuzzer_hunspell_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Stack-buffer-overflow WRITE {*}
Crash Address: 0x7fecb5e69a70
Crash State:
  Hunspell::suggest
  _start
  Hunspell::suggest
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=414841:414879
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=438170:438219

Minimized Testcase (0.09 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96bOvQbTU1EcOoAu377ZA5ne-Emwb3I_AUB-TE0IwmHx2S80eeFU5B1umSiFjFwLgkURxNzR3WGjkvE2__5X10Rac3Mhcb8QMyCNEFW7gx8MrhiQtla-80No9s-u_1EH-IfTnCLrhGRHT7B4EfyXQGQWXjEQg?testcase_id=6720769892810752

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Dec 14 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6720769892810752 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 13 by sheriffbot@chromium.org, Dec 14 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 14 by sheriffbot@chromium.org, Mar 22 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck

Sign in to add a comment