[content setting] add setting for PDF Documents |
||||
Issue descriptionMD Site settings should offer a control that lets users decide whether to open PDF documents in the default viewer or Chrome. See screenshot from existing settings.
,
Nov 9 2016
We don't normally include a period at the end of text in MD. I'm going to assume that the period after "...application." in the image is a typo. Please let me know if the period should be added.
,
Nov 9 2016
We don't normally include a period at the end of text in MD. I'm going to assume that the period after "...application." in the image is a typo. Please let me know if the period should be added.
,
Nov 10 2016
Hey Dave, Correct on the punctuation and toggle, although let's simplify the string to: "Use Chrome as your default PDF viewer" icon can be found here: https://icons.googleplex.com/#icon=ic_drive_pdf&search=pdf
,
Nov 11 2016
"Use Chrome as your default PDF viewer" sounds like it will open PDF documents in Chrome even when I open them from the desktop (outside of Chrome). How about, "Open PDF documents in the current tab"
,
Nov 11 2016
The feature comment 5 references is bug 144693 . I believe pastarmovj@ added the existing non-MD setting.
,
Nov 15 2016
I think I misunderstood. If using the default viewer means NOT using Chrome, then I suggest the following: Open PDFs using a different application o---- (default) Open PDFs using a different application ----o
,
Nov 15 2016
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bc2f0135011d68b7876c3ff5bf645d14ead0853 commit 1bc2f0135011d68b7876c3ff5bf645d14ead0853 Author: dschuyler <dschuyler@chromium.org> Date: Tue Nov 15 22:33:38 2016 [MD settings] settings for pdf documents This CL adds a PDF documents section to the content settings. BUG= 663588 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2484423004 Cr-Commit-Position: refs/heads/master@{#432273} [modify] https://crrev.com/1bc2f0135011d68b7876c3ff5bf645d14ead0853/chrome/app/settings_strings.grdp [modify] https://crrev.com/1bc2f0135011d68b7876c3ff5bf645d14ead0853/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/1bc2f0135011d68b7876c3ff5bf645d14ead0853/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/1bc2f0135011d68b7876c3ff5bf645d14ead0853/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/1bc2f0135011d68b7876c3ff5bf645d14ead0853/chrome/browser/resources/settings/route.js [modify] https://crrev.com/1bc2f0135011d68b7876c3ff5bf645d14ead0853/chrome/browser/resources/settings/settings_resources.grd [add] https://crrev.com/1bc2f0135011d68b7876c3ff5bf645d14ead0853/chrome/browser/resources/settings/site_settings/pdf_documents.html [add] https://crrev.com/1bc2f0135011d68b7876c3ff5bf645d14ead0853/chrome/browser/resources/settings/site_settings/pdf_documents.js [modify] https://crrev.com/1bc2f0135011d68b7876c3ff5bf645d14ead0853/chrome/browser/resources/settings/site_settings_page/site_settings_page.html [modify] https://crrev.com/1bc2f0135011d68b7876c3ff5bf645d14ead0853/chrome/browser/resources/settings/site_settings_page/site_settings_page.js [modify] https://crrev.com/1bc2f0135011d68b7876c3ff5bf645d14ead0853/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Nov 16 2016
dschuyler@: is this fixed now?
,
Nov 16 2016
I have a touch-up CL for the "Open PDFs using a different application" text at CL 2506803002. That could be moved to another bug and this one fixed, or that CL may land soon (it's got an lgtm and cq). I was going to land that then mark this fixed.
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88bfc417f0244004b44720aec76f6bee1a9aaacb commit 88bfc417f0244004b44720aec76f6bee1a9aaacb Author: dschuyler <dschuyler@chromium.org> Date: Wed Nov 16 19:12:37 2016 [MD settings] label for opening PDF in different application This CL changes the label for the setting about opening PDF documents in a different application (rather than within the browser). Since the meaning of the language opposite from the prior label, the |inverted| tag has been removed from the toggle. BUG= 663588 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2506803002 Cr-Commit-Position: refs/heads/master@{#432583} [modify] https://crrev.com/88bfc417f0244004b44720aec76f6bee1a9aaacb/chrome/app/settings_strings.grdp [modify] https://crrev.com/88bfc417f0244004b44720aec76f6bee1a9aaacb/chrome/browser/resources/settings/site_settings/pdf_documents.html [modify] https://crrev.com/88bfc417f0244004b44720aec76f6bee1a9aaacb/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Nov 16 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dschuyler@chromium.org
, Nov 9 2016Summary: [content setting] add setting for PDF Documents (was: New content setting: PDF Documents)