CQ experimental builders aren't skipped if NOTRY=true |
|||||
Issue descriptionIn https://codereview.chromium.org/2482353002 we have the following: NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Despite my ALL CAPS! plea not to try, the CQ still tried ios-simulator-xcode-clang: https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/863 I don't think this try run is visible in the regular Rietveld UI, but I think it may still be a bug that we kicked off that trybot run. It's not clear to me whether this patch was held up due to this bot, or landed independent of it finishing. I'm putting this as P3 since I am not familiar with this trybot, and the patch still landed in ~2 minutes so it wasn't a big deal either way.
,
Nov 15 2016
Sergiyb@ analysis is correct. For consistency, I think we indeed shouldn't run experimental if NOTRY is true.
,
Nov 15 2016
,
Nov 15 2016
https://chrome-internal-review.googlesource.com/305135
,
Nov 15 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/af7b7ee5d25649c8bdfca7c879ff8287d4e61d4d commit af7b7ee5d25649c8bdfca7c879ff8287d4e61d4d Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Nov 15 13:28:11 2016
,
Nov 15 2016
Should be fixed :) |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by serg...@chromium.org
, Nov 14 2016