patricialor@, can you take a look at this please?

https://codereview.chromium.org/2944083004

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d16b69bc237e5f5d2cc75681aec6d2c130a05f14

commit d16b69bc237e5f5d2cc75681aec6d2c130a05f14
Author: tapted <tapted@chromium.org>
Date: Wed Jun 21 10:06:42 2017

Views a11y: Use AX_ROLE_POP_UP_BUTTON for views::Combobox.

AX_ROLE_COMBO_BOX is for UI elements with an editable textfield, which
views::Combobox does not have. views::Combobox operates most like an
HTML <select> element, which is given kPopUpButtonRole in Blink's
AXNodeObject.cpp (or kListBoxRole if it allows multiple selection).

Use AX_ROLE_POP_UP_BUTTON for views::Combobox on all platforms.

BUG= 657900 ,  663536 

Review-Url: https://codereview.chromium.org/2946783003
Cr-Commit-Position: refs/heads/master@{#481163}

[modify] https://crrev.com/d16b69bc237e5f5d2cc75681aec6d2c130a05f14/ui/views/controls/combobox/combobox.cc

Is this now Fixed?

I think that exposes the action, but the stuff in https://codereview.chromium.org/2944083004 is needed to respond to it

Tested this issue using latest version #61.0.3141.0 on Mac 10.12.5.

Observing the same behavior in reported version (56.0.2906.0) and latest version (61.0.3141.0) as well.

Please find the below screen cast's of both the versions and confirm the behavior.

Thanks!!

Deleted: Jun 27 2017 2-45 PM.webm 3.5 MB

	Jun 27 2017 2-45 PM.webm 3.5 MB View Download

Deleted: Jun 27 2017 2-47 PM.webm 3.4 MB

	Jun 27 2017 2-47 PM.webm 3.4 MB View Download

 Issue 657900  has been merged into this issue.

#c11:
> the stuff in https://codereview.chromium.org/2944083004 is needed

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/926329391ace2c7470f55b275988a09f4f1fd06b

commit 926329391ace2c7470f55b275988a09f4f1fd06b
Author: tapted <tapted@chromium.org>
Date: Mon Jul 03 04:16:16 2017

MacViews a11y: Support the "Show menu" action in Textfield and Combobox.

Currently Combobox and Textfield show no actions available to
accessibility.

For Mac, fix by mapping the default action (a click) to
NSAccessibilityPressAction and map AX_ACTION_SHOW_CONTEXT_MENU to
NSAccessibilityShowMenuAction. For comboboxes, both
NSAccessibilityPressAction and NSAccessibilityShowMenuAction show a
menu. For textfields, just the latter.

On Mac, automatically add and handle NSAccessibilityShowMenuAction for
controls that show a menu on press and don't have a separate context
menu.

For Textfields (and other controls using context menus), automatically
add ui::AX_ACTION_SHOW_CONTEXT_MENU for views that have a context menu
controller.

Comboboxes are trickier since the View that usually handles clicks is a
"TransparentButton". So handle these actions explicitly.

For menus triggered by a11y actions, there may be no mouse event. Cocoa
needs one to position the menu, so generate a dummy event for this.

BUG= 679247 ,  663536 ,  732655 

Review-Url: https://codereview.chromium.org/2944083004
Cr-Commit-Position: refs/heads/master@{#483939}

[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/accessibility/platform/ax_platform_node_mac.h
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/views/accessibility/native_view_accessibility_base.cc
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/views/controls/combobox/combobox.cc
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/views/controls/combobox/combobox.h
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/views/controls/combobox/combobox_unittest.cc
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/views/controls/menu/menu_runner_impl_cocoa.mm
[modify] https://crrev.com/926329391ace2c7470f55b275988a09f4f1fd06b/ui/views/widget/native_widget_mac_accessibility_unittest.mm