New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663533 link

Starred by 7 users

Issue metadata

Status: Duplicate
Merged: issue 842238
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 450821



Sign in to add a comment

Frame viewer tracing no longer shows pictures with layers

Project Member Reported by enne@chromium.org, Nov 8 2016

Issue description

When doing a frame viewer trace at ToT, the pictures are no longer shown in the layer view.

The cc::DisplayItemList track appears just fine in both renderer and browser and the rasterization result is shown (so long as I pass --enable-skia-benchmarking on the command line).  However, on the cc::LayerTreeHostImpl track, the Contents checkbox does nothing and there's a "Some problems were encountered" butter bar.  When clicked, it suggests that "Your trace didn't have pictures for every layer. Old chrome versions had this problem".

I'm not sure if this is an issue on the tracing side of things or on the cc side of things with the data that it's submitting or both.  Probably things haven't quite been updated as slimming paint changed from pictures to display lists.

chrishtr: can you triage this and find somebody on the paint team to do some investigation?
 
Owner: schenney@chromium.org
Stephen, could you please bisect to see if this broke recently? We did make it
work for SPv1, something changed to break at some point in the past months.
Are there any errors in the javascript console?
Status: Assigned (was: Available)

Comment 4 by enne@chromium.org, Nov 8 2016

No, nothing obvious in the console, other than:

While processing delete of {pid: 12756, scope: ptr, id: 0x1} at ts=3377385963.6870003: Error: Deleting object cc::LayerTreeHostImpl with a different category than when it was created. It previous had cat=disabled-by-default-cc.debug,disabled-by-default-cc.debug.quads,disabled-by-default-devtools.timeline.layers but the delete command had cat=disabled-by-default-cc.debug
Cc: mcolbert@chromium.org

Comment 6 by sunxd@chromium.org, Nov 29 2016

Cc: sunxd@chromium.org
I noticed something wrong with frame viewer months ago, before the layer tree disappeared: if I try to rotate or move the layer quads of layer tree in frameviewer, it not only rotate/move the tree but also zoom in with very large scale. Could there be  anything wrong with the js code?

Also, devtools still work fine with layer tree tracing, so it is very likely that catapult breaks things.
Cc: aiolos@chromium.org
Components: Speed>Tracing
Components: -Internals>Tracing
I encountered the same issue today in Chrome Canary 59.0.3036.0.
Steps to repro: Start Chrome with --enable-skia-benchmarking, check "Frame Viewer" profile, click Record, click on LayerTreeHostImpl snapshots. The frame viewer shows "Some problem were encountered." 


JS Console shows:

Uncaught TypeError: Cannot read property 'forEach' of undefined
    at HTMLElement.set displayItemList [as displayItemList] (chrome://tracing/tracing.js:6443:2774)
    at HTMLElement.updateContents (chrome://tracing/tracing.js:6461:42)
    at HTMLElement.set objectSnapshot [as objectSnapshot] (chrome://tracing/tracing.js:4489:1029)
    at HTMLElement.set modelEvent [as modelEvent] (chrome://tracing/tracing.js:4489:875)
    at HTMLElement.set selection [as selection] (chrome://tracing/tracing.js:4492:361)
    at createSubView (chrome://tracing/tracing.js:4514:107)
    at chrome://tracing/tracing.js:4518:392
    at Map.forEach (native)
    at HTMLElement.onSelectionChanged_ (chrome://tracing/tracing.js:4518:341)


I also commented on  Issue 688185  which probably can be merged into this one.
Screen Shot 2017-03-09 at 10.48.23 PM.png
296 KB View Download
Cc: nduca@chromium.org
 Issue 688185  has been merged into this issue.

Comment 12 by enne@chromium.org, Apr 27 2018

Blockedon: 450821

Comment 13 by enne@chromium.org, Jun 4 2018

Mergedinto: 842238
Status: Duplicate (was: Assigned)

Sign in to add a comment