"Enter passphrase" link not working in CrOS |
|||||
Issue descriptionENVIRONMENT and STATS OS: Chrome Chrome version: 56.0.2910.0 Dev channel Platform: 8970.0.0 Winky REPRO STEPS 1. Sign in to Chrome on two devices (desktop and chromebook) 2. On desktop Chrome go to advanced sync settings (chrome://settings/syncSetup) and set custom passphrase. 3. On Chromebook make sure that a notification is displayed to enter the custom passphrase. 1. Sign in to Chromebook with an account which has custom passphrase set. 2. Dismiss the sync error which is shown in the bottom right corner. 3. Open chrome://settings in a new tab and scroll down to "People" section. 4. Click on the "Enter passphrase" link ACTUAL RESULTS Nothing happens EXPECTED RESULTS Advanced sync settings dialog is opened with the option to enter the passphrase ADDITIONAL INFO This looks like a recent regression. Worked fine in 56.0.2906.0 dev
,
Nov 10 2016
Assigning to mahmadi@, I think this is a result of https://codereview.chromium.org/2457483002/
,
Nov 11 2016
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d0d4287db7ff0d694e1695bb640c1cb0a29e737 commit 7d0d4287db7ff0d694e1695bb640c1cb0a29e737 Author: mahmadi <mahmadi@chromium.org> Date: Thu Nov 17 18:52:06 2016 [MD Settings][Options] Fixes bugs with the sync status messages/actions 1. Fixes a wrong callback handler name in the MD settings page. 2. Updates the old settings page to handle the new more-precise sync error states that were implemented for MD Settings. screenshots: https://screenshot.googleplex.com/2Ob1e23X9z7 https://screenshot.googleplex.com/SQ4vjNAxqbf https://screenshot.googleplex.com/sN6FakgQPn9 https://screenshot.googleplex.com/uaeNOf9ukx2 BUG= 663505 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2492293002 Cr-Commit-Position: refs/heads/master@{#432928} [modify] https://crrev.com/7d0d4287db7ff0d694e1695bb640c1cb0a29e737/chrome/browser/resources/options/browser_options.js [modify] https://crrev.com/7d0d4287db7ff0d694e1695bb640c1cb0a29e737/chrome/browser/resources/options/sync_setup_overlay.js [modify] https://crrev.com/7d0d4287db7ff0d694e1695bb640c1cb0a29e737/chrome/browser/sync/sync_ui_util.cc [modify] https://crrev.com/7d0d4287db7ff0d694e1695bb640c1cb0a29e737/chrome/browser/ui/webui/options/browser_options_handler.cc [modify] https://crrev.com/7d0d4287db7ff0d694e1695bb640c1cb0a29e737/chrome/browser/ui/webui/settings/people_handler.cc [modify] https://crrev.com/7d0d4287db7ff0d694e1695bb640c1cb0a29e737/chrome/browser/ui/webui/settings/people_handler.h
,
Nov 17 2016
,
Nov 29 2016
"Enter passphrase" link working fine now. Verified in ChromeOS version 56.0.2924.7. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by s...@chromium.org
, Nov 9 2016Status: Assigned (was: Untriaged)