New issue
Advanced search Search tips

Issue 663501 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Web MIDI sending / receiving messages seems broken

Reported by anjipa...@gmail.com, Nov 8 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.87 Safari/537.36

Steps to reproduce the problem:
1. request MIDI Access (http|https). successful
2. add onmidimessage listener, console.log midimessage
3. play midi device

What is the expected behavior?
sending / receiving midi messages should output data in the browser console.

What went wrong?
no data is shown when playing the midi device

Did this work before? Yes previous release of chrome canary. sorry, i don't know the version

Chrome version: 56.0.2913.3  Channel: canary
OS Version: OS X 10.12.1
Flash Version: Shockwave Flash 23.0 r0
 
Components: Blink>WebMIDI
Owner: toyoshim@chromium.org
Status: Started (was: Unconfirmed)
Thank you for reporting this issue.
I confirmed that this problem exists on Canary.
Probably one of recent changes cause this.
anjipanji, thank you for catching this.
Now, I have a fix and will commit this change soon.
FYI, https://codereview.chromium.org/2487113002/ this is the fix, but still under code review.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac5d7642d517d225a02d66804a26a49a9bb4567e

commit ac5d7642d517d225a02d66804a26a49a9bb4567e
Author: toyoshim <toyoshim@chromium.org>
Date: Mon Nov 14 10:36:48 2016

Web MIDI: fix a regression of r430234

This issue depends on platform on that how devices are initialized,
but at least on macOS, this causes problems that devices
get not responsive.

BUG= 663501 

Review-Url: https://codereview.chromium.org/2487113002
Cr-Commit-Position: refs/heads/master@{#431851}

[modify] https://crrev.com/ac5d7642d517d225a02d66804a26a49a9bb4567e/components/test_runner/mock_web_midi_accessor.cc
[modify] https://crrev.com/ac5d7642d517d225a02d66804a26a49a9bb4567e/components/test_runner/mock_web_midi_accessor.h
[add] https://crrev.com/ac5d7642d517d225a02d66804a26a49a9bb4567e/third_party/WebKit/LayoutTests/webmidi/add-port.html
[modify] https://crrev.com/ac5d7642d517d225a02d66804a26a49a9bb4567e/third_party/WebKit/LayoutTests/webmidi/implicit-open-expected.txt
[modify] https://crrev.com/ac5d7642d517d225a02d66804a26a49a9bb4567e/third_party/WebKit/LayoutTests/webmidi/open-close-expected.txt
[modify] https://crrev.com/ac5d7642d517d225a02d66804a26a49a9bb4567e/third_party/WebKit/LayoutTests/webmidi/requestmidiaccess-expected.txt
[modify] https://crrev.com/ac5d7642d517d225a02d66804a26a49a9bb4567e/third_party/WebKit/LayoutTests/webmidi/requestmidiaccess.html
[modify] https://crrev.com/ac5d7642d517d225a02d66804a26a49a9bb4567e/third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp

Status: Fixed (was: Started)

Sign in to add a comment