New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 663499 link

Starred by 2 users
Status: Fixed
Owner:
█ jaydasika@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
weiliangc@chromium.org
ajuma@chromium.org
sunxd@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK failure in cc/trees/draw_property_utils.cc

Project Member Reported by jaydasika@chromium.org, Nov 8 2016 
Steps:
1) Build chrome with dchecks on.
2) Launch chrome and navigate to http://cb.vu/unixtoolbox.pdf
3) Click on 'Bookmarks' icon and then click on arrow icon beside 'Processes'

[1:3:1108/115431:FATAL:draw_property_utils.cc(1237)] Check failed: parent_clip_node->target_transform_id < transform_tree.TargetId(transform_node->id) (12 vs. 0)

Comment 1 by jaydasika@chromium.org, Nov 28 2016

Cc: -jaydasika@chromium.org
Owner: jaydasika@chromium.org
Status: Assigned (was: Available)
I think the DCHECK is wrong and needs to be removed. If we have a scroll child, there can be a render surface which is an ancestor of scroll parent's target but a descendant of scroll child's target and we will hit this DCHECK in that case.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4de4c083e4e6500ef998c9a040388c1f58013b6e

commit 4de4c083e4e6500ef998c9a040388c1f58013b6e
Author: jaydasika <jaydasika@chromium.org>
Date: Tue Nov 29 16:19:16 2016

cc : Remove invalid DCHECK from draw_property_utils.cc

The DCHECK is invalid because we can have a render surface between the
target of scroll parent and scroll child.

BUG= 663499 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2537053002
Cr-Commit-Position: refs/heads/master@{#435008}

[modify] https://crrev.com/4de4c083e4e6500ef998c9a040388c1f58013b6e/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/4de4c083e4e6500ef998c9a040388c1f58013b6e/cc/trees/layer_tree_host_common_unittest.cc

Comment 3 by jaydasika@chromium.org, Nov 30 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment