New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 663488 link

Starred by 6 users
Status: Untriaged
Owner: ----
Cc:
omrilio@chromium.org
█ smckay@chromium.org
weifangsun@chromium.org
█ xutan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Custom wallpaper selector dialog is ugly

Project Member Reported by derat@chromium.org, Nov 8 2016 
The custom wallpaper selector dialog (chrome/browser/resources/chromeos/wallpaper_manager/main.html) has some visual issues:

1. There should be more horizontal padding between "Choose File" and the selected filename. This might just be the way Blink draws <input type="file">. :-(

2. The exclamation point icon is low-res and vertically misaligned. The icon is at chrome/browser/resources/chromeos/wallpaper_manager/images/ui/remember.png. I'm attaching a copy.

Elizabeth, do you know if we have a high-DPI version of this icon? The checked-in version is 17x17, so I'd guess we need 34x34.
Screenshot 2016-11-01 at 16.01.22.png
65.2 KB View Download
remember.png
341 bytes View Download

Comment 1 by elizabethchiu@chromium.org, Dec 13 2016 

Here is the updated design for the dialog box. I'm putting together the spec and will send it to you later tomorrow.
alert-icon-200.svg
1.2 KB Download

Comment 2 by elizabethchiu@chromium.org, Dec 13 2016

add-image.png
401 KB View Download

Comment 3 by elizabethchiu@chromium.org, Dec 13 2016

Owner: derat@chromium.org

Comment 4 by tbuck...@chromium.org, Feb 20 2017

Cc: omrilio@chromium.org
+omrilio for wallpaper picker

Comment 5 by derat@chromium.org, Feb 21 2017

Cc: -omrilio@chromium.org
Owner: omrilio@chromium.org
Status: Untriaged (was: Assigned)
Thanks for the updated design!

Like I mentioned earlier, I'm not sure how much control we have over how the file picker button and filename are drawn.

Comment 6 by omrilio@chromium.org, Feb 21 2017

Cc: omrilio@chromium.org
Owner: weifangsun@chromium.org
Yep, we are looking into updating the picker +Weifang who's working on it

Comment 7 by weifangsun@chromium.org, Feb 23 2017

Cc: xutan@chromium.org smckay@chromium.org
Components: Platform>Apps>FileManager

Comment 8 by sashab@chromium.org, Feb 24 2018

Cc: weifangsun@chromium.org
Labels: CrOS-FilesApp-UI
Owner: ----
<files-triage>

Comment 9 by tbuck...@chromium.org, Feb 24 2018

Cc: -tbuck...@chromium.org

Comment 10 by weifangsun@chromium.org, Feb 26 2018

Components: UI>Shell>Wallpaper
omrilio@ - Given the merging/updates you're making to the Wallpaper app, is there a preferred/different approach to the picker than what is currently in place?

Comment 11 by omrilio@chromium.org, Feb 27 2018

Labels: M-67
We will change the whole wallpaper picker in the upcoming milestone (hopefully)
M67.

Comment 12 by sashab@chromium.org, Feb 28 2018

Components: -Platform>Apps>FileManager
Labels: -CrOS-FilesApp-UI
Sounds like this bug doesn't belong in the FileManager component. Should we move future bugs to UI>Shell>Wallpaper as well?
►

Sign in to add a comment