New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 663470 link

Starred by 2 users
Status: Fixed
Owner:
█ mbrunson@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 651282



Sign in to add a comment

Move connection logic to DeviceDetailsView when it's added to chrome://bluetooth-internals

Project Member Reported by mbrunson@chromium.org, Nov 8 2016 
Connection logic and device service caching logic needs to be moved to DeviceDetailsView once it is added.

Comment 1 by mbrunson@chromium.org, Nov 10 2016

Summary: Move connection logic to DeviceDetailsView when it's added on chrome://bluetooth-internals (was: Move subscribe statements to DevicesView when it's added on chrome://bluetooth-internals)

Comment 2 by mbrunson@chromium.org, Nov 10 2016

Description: Show this description

Comment 3 by mbrunson@chromium.org, Nov 10 2016

Summary: Move connection logic to DeviceDetailsView when it's added to chrome://bluetooth-internals (was: Move connection logic to DeviceDetailsView when it's added on chrome://bluetooth-internals)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feda9ca742d2220f0da0d81e17f51a4917375405

commit feda9ca742d2220f0da0d81e17f51a4917375405
Author: mbrunson <mbrunson@chromium.org>
Date: Fri Jan 13 02:15:20 2017

bluetooth: Add device details page with basic properties to internals page.

Adds DeviceDetailsPage to internals page so users can view all the properties
of the DeviceInfo object. No display of service properties is included in this
patch.

Splits action link in Devices table into two separate links: "Inspect"
and "Forget".
Adds functions to add and remove items from the sidebar.
Adds test infrastructure for Device proxy-based tests.
Adds test for DeviceDetailsPage.
Adds unregister function to PageManager.

GIFs: https://goo.gl/photos/zLiv86gyYmQhRn9w8

BUG= 651282 , 663470 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2576603002
Cr-Commit-Position: refs/heads/master@{#443465}

[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/browser_resources.grd
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/bluetooth_internals.css
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/device_collection.js
[add] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/device_details_page.js
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/device_table.js
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/devices_page.js
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/sidebar.js
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/test/data/webui/bluetooth_internals_browsertest.js
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/ui/webui/resources/js/cr/ui/page_manager/page_manager.js

Comment 5 by mbrunson@chromium.org, Jan 13 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment