New issue
Advanced search Search tips

Issue 663469 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove forwarding includes for iOS prefs

Project Member Reported by rohitrao@chromium.org, Nov 8 2016

Issue description

ios/chrome/browser/pref_names.h contains some forwarding includes to keep downstream files compiling as we move prefs around.  Once the downstream code has been updated to use the new pref locations, we can remove the forwarding headers.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/c860646462cef7433583bd7d9d07625118ae352b

commit c860646462cef7433583bd7d9d07625118ae352b
Author: sdefresne <sdefresne@google.com>
Date: Wed Dec 14 15:23:02 2016

Owner: sdefresne@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8

commit d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8
Author: sdefresne <sdefresne@chromium.org>
Date: Wed Dec 14 16:59:36 2016

Split //ios/chrome/browser/prefs to prevent circular dependencies.

Having ios/chrome/browser/prefs/browser_prefs.h part of the target
will cause circular dependency when downstream code is upstreamed,
so split to a separate target in preparation.

Clean some forwarding-include in ios/chrome/browser/pref_names.h.

BUG= 663469 

Review-Url: https://codereview.chromium.org/2574213002
Cr-Commit-Position: refs/heads/master@{#438535}

[modify] https://crrev.com/d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8/ios/chrome/browser/browser_state/BUILD.gn
[modify] https://crrev.com/d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8/ios/chrome/browser/device_sharing/BUILD.gn
[modify] https://crrev.com/d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8/ios/chrome/browser/device_sharing/device_sharing_manager.mm
[modify] https://crrev.com/d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8/ios/chrome/browser/device_sharing/device_sharing_manager_unittest.mm
[modify] https://crrev.com/d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8/ios/chrome/browser/pref_names.h
[modify] https://crrev.com/d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8/ios/chrome/browser/prefs/BUILD.gn
[modify] https://crrev.com/d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8/ios/chrome/browser/signin/BUILD.gn
[modify] https://crrev.com/d12ee2168a3e3c4a0bd8decb22677aeb3ac0e5d8/ios/chrome/test/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment