New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663414 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 620813
issue 663918



Sign in to add a comment

Create interface for writing field trial allocator data format

Reported by lawrencewu@chromium.org, Nov 8 2016

Issue description

To help the breadcrumbs project in diagnosing crashes, we should create an interface when writing the data format to the field trial allocator so it takes in the allocator.
 
Blocking: 663918
Blocking: 620813
Cc: manzagop@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b688cc0790c38b70a391a6c2bbbb36c7b7628a8

commit 1b688cc0790c38b70a391a6c2bbbb36c7b7628a8
Author: lawrencewu <lawrencewu@chromium.org>
Date: Sat Dec 10 02:38:23 2016

Add field trial dump and retrieval methods from shared memory

The Breadcrumbs project dumps system state to a persistent file so that it can
be analyzed after a crash.  We want to include in that the complete set of field
trials.  That means saving them to the file when the browser starts and being
able to retrieve them from the file on a future run; they will be loaded into a
protobuf and uploaded.

BUG= 663414 

Review-Url: https://codereview.chromium.org/2560723004
Cr-Commit-Position: refs/heads/master@{#437732}

[modify] https://crrev.com/1b688cc0790c38b70a391a6c2bbbb36c7b7628a8/base/metrics/field_trial.cc
[modify] https://crrev.com/1b688cc0790c38b70a391a6c2bbbb36c7b7628a8/base/metrics/field_trial.h
[modify] https://crrev.com/1b688cc0790c38b70a391a6c2bbbb36c7b7628a8/base/metrics/field_trial_unittest.cc

Status: Fixed (was: Assigned)
As commented on the CL, this is gets us a long way but I think it doesn't give up-to-date info about whether a trial is "active", ie it's a one-shot dump. Wdyt?

Sign in to add a comment