New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 663409 link

Starred by 0 users
Status: Available
Owner: ----
Cc:
javierrobles@google.com
█ noyau@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Remove the usage of -[NSString UTF8String] from iOS code

Project Member Reported by vabr@chromium.org, Nov 8 2016 
In all places where base::SysNSStringToUTF8 could be used instead of UTF8String, we should use the former. That way we might avoid bugs like issue 653379 in the future. This should be done both in the internal, as well as the public code.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/a6111ceff053fd4ca0a147d3eb5657f3db737e13

commit a6111ceff053fd4ca0a147d3eb5657f3db737e13
Author: vabr <vabr@google.com>
Date: Wed Nov 09 14:46:06 2016

Comment 2 by justincohen@chromium.org, Mar 23 2017

Labels: Hotlist-Needs-New-Component

Comment 3 by eugene...@chromium.org, May 30 2017

Components: Internals
Labels: -Type-Bug -Hotlist-Needs-New-Component Type-Task

Comment 4 by eugene...@chromium.org, Aug 25 2017

Labels: Hotlist-GoodFirstBug
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c9dc0ca9554916db2e827607f3be8b3eceeb86d

commit 8c9dc0ca9554916db2e827607f3be8b3eceeb86d
Author: Eric Noyau <noyau@google.com>
Date: Tue Oct 03 14:33:16 2017

Replacing -UTF8String with SysNSStringToUTF8

Bug: 663409
Change-Id: I24478f88054c31190d38d377469865fcda874aba
Reviewed-on: https://chromium-review.googlesource.com/697584
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506032}
[modify] https://crrev.com/8c9dc0ca9554916db2e827607f3be8b3eceeb86d/ios/net/cookies/cookie_store_ios.mm

Comment 6 by pkl@chromium.org, Jan 31 2018

Cc: noyau@chromium.org javierrobles@google.com
►

Sign in to add a comment