New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 663354 link

Starred by 1 user
Status: Fixed
Owner:
█ msarett@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
scroggo@chromium.org
altimin@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

JPEGImageDecoderTest.manyProgressiveScans takes 26 seconds to run.

Project Member Reported by altimin@chromium.org, Nov 8 2016 
https://crrev.com/2482883002 added a new JPEGImageDecoderTest.manyProgressiveScans test, which takes 26 seconds to run in Debug mode. (13 seconds in Release).

This is a significant regression, given that all other blink_platform_unittests take ~2 seconds to run in Debug mode.

Comment 1 by msarett@chromium.org, Nov 8 2016

Cc: scroggo@chromium.org
Is there a way to mark a test as slow and not run it all the time?  Maybe this should belong to a different test suite?

It is maybe possible to write a faster test (using a smaller image), but testing this behavior (aborting on a denial-of-service jpeg) is going to take a long time compared to other tests.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3baac7bfbce401ba30bd36b6210561f9bda2f94d

commit 3baac7bfbce401ba30bd36b6210561f9bda2f94d
Author: msarett <msarett@google.com>
Date: Tue Nov 08 22:08:01 2016

Replace many-progressive-scans test image with smaller version

Drops test time to 1ms on my Linux machine.

BUG= 663354 
BUG= 642462 

Review-Url: https://codereview.chromium.org/2486043002
Cr-Commit-Position: refs/heads/master@{#430734}

[modify] https://crrev.com/3baac7bfbce401ba30bd36b6210561f9bda2f94d/third_party/WebKit/Source/platform/image-decoders/testing/many-progressive-scans.jpg

Comment 3 by msarett@chromium.org, Nov 9 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment