New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 663353 link

Starred by 1 user
Status: Assigned
Owner:
█ hjd@chromium.org
Last visit > 30 days ago
Cc:
█ picksi@chromium.org
boliu@chromium.org
primiano@chromium.org
█ kraynov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MemoryInfra: improve documentation and link it from TraceViewer

Project Member Reported by primiano@chromium.org, Nov 8 2016 
Background context:go/memory-infra: memory profiling in chrome://tracing

Copying this from Issue 661504. Comment #27 is spot-on, we should:
1) Have all the docs in a consistent place
2) Have them linked from the traceviewer UI and results.html page.

-----
There were no tooltips for me in traces; no idea what I needed to hover over. But https://chromium.googlesource.com/chromium/src/+/master/cc/memory.md was really really helpful.

It would be wonderful if everything in memory infra, and perf test graphs etc, would link to some documentation like that. The general "what is this value" is a very common first question for me when I get assigned a perf regression.
-----

Comment 1 by hjd@chromium.org, Nov 8 2016

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/145f953df3277bf2b1676d5ce005a519a4b9bfd3

commit 145f953df3277bf2b1676d5ce005a519a4b9bfd3
Author: hjd <hjd@chromium.org>
Date: Thu Nov 10 12:53:56 2016

Fix a link in components/tracing/docs/memory_infra.md

BUG=chromium:663353

Review-Url: https://codereview.chromium.org/2485393002
Cr-Commit-Position: refs/heads/master@{#431236}

[modify] https://crrev.com/145f953df3277bf2b1676d5ce005a519a4b9bfd3/components/tracing/docs/memory_infra.md
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0304f11a58c3a10b78a12c317d18f553d4cbb889

commit 0304f11a58c3a10b78a12c317d18f553d4cbb889
Author: hjd <hjd@chromium.org>
Date: Mon Nov 14 22:36:53 2016

Move memory docs to docs/memory-infra

I replaced the old documents with links that redirect to
the new locations so we don't break external links.
Also fixes a couple of broken links I found.

BUG=chromium:663353

Review-Url: https://codereview.chromium.org/2494063002
Cr-Commit-Position: refs/heads/master@{#431920}

[modify] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/base/allocator/README.md
[modify] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/cc/memory.md
[modify] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/components/tracing/docs/adding_memory_infra_tracing.md
[modify] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/components/tracing/docs/heap_profiler.md
[modify] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/components/tracing/docs/heap_profiler_internals.md
[modify] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/components/tracing/docs/memory_infra.md
[modify] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/components/tracing/docs/memory_infra_gpu.md
[modify] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/components/tracing/docs/memory_infra_startup_tracing.md
[add] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/docs/memory-infra/README.md
[add] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/docs/memory-infra/adding_memory_infra_tracing.md
[add] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/docs/memory-infra/heap_profiler.md
[add] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/docs/memory-infra/heap_profiler_internals.md
[add] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/docs/memory-infra/memory_infra_startup_tracing.md
[add] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/docs/memory-infra/probe-cc.md
[add] https://crrev.com/0304f11a58c3a10b78a12c317d18f553d4cbb889/docs/memory-infra/probe-gpu.md

Comment 4 by primiano@chromium.org, Jan 4 2017

Components: Internals>Instrumentation>Memory
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dddc3fac1b1033d6ae85cad37a15c831fe7c156

commit 9dddc3fac1b1033d6ae85cad37a15c831fe7c156
Author: hjd <hjd@chromium.org>
Date: Wed Jan 11 16:16:37 2017

Add effective size vs. size explanation to docs

BUG=chromium:663353

Review-Url: https://codereview.chromium.org/2621993004
Cr-Commit-Position: refs/heads/master@{#442917}

[modify] https://crrev.com/9dddc3fac1b1033d6ae85cad37a15c831fe7c156/docs/memory-infra/README.md
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2659229674299f9bb7f3c3c8121fe4f493ee0abf

commit 2659229674299f9bb7f3c3c8121fe4f493ee0abf
Author: hjd <hjd@chromium.org>
Date: Thu Jan 12 11:45:47 2017

Fix links in Source/wtf/Allocator.md

BUG=chromium:663353

Review-Url: https://codereview.chromium.org/2488933002
Cr-Commit-Position: refs/heads/master@{#443209}

[modify] https://crrev.com/2659229674299f9bb7f3c3c8121fe4f493ee0abf/third_party/WebKit/Source/wtf/Allocator.md
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/552a72f3e4266b85153e64a98a10ae614c10a176

commit 552a72f3e4266b85153e64a98a10ae614c10a176
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Jan 12 13:58:11 2017

Roll src/third_party/catapult/ 6377613b1..0e201cdd0 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6377613b1a29..0e201cdd06ed

$ git log 6377613b1..0e201cdd0 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 hjd Hopefully this will make it easier for people coming to the memory infra UI for the first time to understand what is happening.

BUG=663353

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2622363004
Cr-Commit-Position: refs/heads/master@{#443218}

[modify] https://crrev.com/552a72f3e4266b85153e64a98a10ae614c10a176/DEPS
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/802d496c4241a02ff2164c68ff480181b34f7873

commit 802d496c4241a02ff2164c68ff480181b34f7873
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Mon Feb 13 13:17:55 2017

Roll src/third_party/catapult/ 623e8078b..6fa9f83f7 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/623e8078bffa..6fa9f83f7490

$ git log 623e8078b..6fa9f83f7 --date=short --no-merges --format='%ad %ae %s'
2017-02-13 hjd [tracing] Add link to memory-infra documentation to tracing UI

Created with:
  roll-dep src/third_party/catapult
BUG=663353

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2696543002
Cr-Commit-Position: refs/heads/master@{#449938}

[modify] https://crrev.com/802d496c4241a02ff2164c68ff480181b34f7873/DEPS
►

Sign in to add a comment