Issue metadata
Sign in to add a comment
|
Crash in views::InkDropRipple::HideImmediately |
||||||||||||||||||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=4723602365874176 Fuzzer: ochang_domfuzzer Job Type: linux_asan_chrome_v8_arm Platform Id: linux Crash Type: UNKNOWN READ Crash Address: 0x00000000 Crash State: views::InkDropRipple::HideImmediately views::InkDropImpl::HideHighlightOnRippleHiddenState::AnimationStarted views::InkDropImpl::AnimationStarted Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_v8_arm&range=430398:430495 Minimized Testcase (0.05 Kb): Download: https://cluster-fuzz.appspot.com/download/AMIfv97NBWHYHfpbP-bu40K_iuY4quAMef1VVVbrW6DLNo-mO42UhUigc3NBU3vk2O9htsjfuveFhq3GtG8kIUBY83_CN90-q89Stts6ySdUBvyv0nzz3ePO4rb5BE_67WbyFngQ7vEngJJsJS9E2ICh8XF2RWaKsA?testcase_id=4723602365874176 <script> document.designMode = 'on'; ; ;</script> Additional requirements: Requires Gestures Issue filed automatically. See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Nov 8 2016
,
Nov 8 2016
This is probably caused by my change, I will look.
,
Nov 8 2016
It isn't exactly clear how this issue will manifest itself but it requires the following things to be true: - the button has to be using an ink drop - the button has to have keyboard focus - a DEACTIVATED ink drop animation has to be triggered. The underlying problem is that all animations are being aborted on a LayerAnimator which causes an AnimationStarted() handler to attempt to kick off another animation on an already destroyed InkDropRipple instance. ajuma@, perhaps we can sync up offline about this, but as a client of the LayerAnimator API I am somewhat surprised that calling LayerAnimator::AbortAllAnimations() could possibly cause an AnimationStarted() event. Is it intentional/desired that all sequences notify of a Started event before and Ended/Aborted event?
,
Nov 8 2016
Quick fix here: https://codereview.chromium.org/2487723003/
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71e742597731adbca120dd6961dc8c5fe66bc1f0 commit 71e742597731adbca120dd6961dc8c5fe66bc1f0 Author: bruthig <bruthig@chromium.org> Date: Tue Nov 08 19:07:24 2016 [ash-md] Fixed crash when DEACTIVATING a focused ink drop button. Fixing regression caused by https://codereview.chromium.org/2447523002. The issue is InkDropImpl::HideHighlightOnRippleHiddenState::AnimationStarted() is trying to kick off an animation on an InkDropRipple instance that is already being destroyed. This is due to a LayerAnimationObserver::OnLayerAnimationStarted() event being raised within a LayerAnimator::AbortAllAnimations() call. This change is a short term fix to prevent crashes. We will need to investigate how/if the animation framework should be supporting such a use case. TEST=InkDropImplHideAutoHighlightTest.NoCrashDuringRippleTearDown BUG= 663335 Review-Url: https://codereview.chromium.org/2487723003 Cr-Commit-Position: refs/heads/master@{#430677} [modify] https://crrev.com/71e742597731adbca120dd6961dc8c5fe66bc1f0/ui/views/animation/ink_drop_impl.cc [modify] https://crrev.com/71e742597731adbca120dd6961dc8c5fe66bc1f0/ui/views/animation/ink_drop_impl_unittest.cc
,
Nov 9 2016
,
Nov 9 2016
Marking as fixed and spinning off issue 663579 to track follow up effort.
,
Nov 9 2016
ClusterFuzz has detected this issue as fixed in range 430672:430792. Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4723602365874176 Fuzzer: ochang_domfuzzer Job Type: linux_asan_chrome_v8_arm Platform Id: linux Crash Type: UNKNOWN READ Crash Address: 0x00000000 Crash State: views::InkDropRipple::HideImmediately views::InkDropImpl::HideHighlightOnRippleHiddenState::AnimationStarted views::InkDropImpl::AnimationStarted Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_v8_arm&range=430398:430495 Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_v8_arm&range=430672:430792 Minimized Testcase (0.05 Kb): Download: https://cluster-fuzz.appspot.com/download/AMIfv97NBWHYHfpbP-bu40K_iuY4quAMef1VVVbrW6DLNo-mO42UhUigc3NBU3vk2O9htsjfuveFhq3GtG8kIUBY83_CN90-q89Stts6ySdUBvyv0nzz3ePO4rb5BE_67WbyFngQ7vEngJJsJS9E2ICh8XF2RWaKsA?testcase_id=4723602365874176 <script> document.designMode = 'on'; ; ;</script> Additional requirements: Requires Gestures See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Nov 22 2016
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Nov 8 2016Owner: bruthig@chromium.org
Status: Assigned (was: Untriaged)