Jochen owns the popup blocker code.

Seen today, e.g., on https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/48784
(log attached).

Deleted: Log File contents.html 5.3 KB

Log File contents.html 5.3 KB View Download

https://codereview.chromium.org/2488293002/ is in flight disabling this test on Linux.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e377a797a25fc281e1fe818b1cb77576e2e8e46

commit 1e377a797a25fc281e1fe818b1cb77576e2e8e46
Author: vabr <vabr@chromium.org>
Date: Thu Nov 10 16:05:58 2016

Disable UnblockedPopupShowsInHistoryAndOmnibox on Linux

PopupBlockerBrowserTest.UnblockedPopupShowsInHistoryAndOmnibox is flaky on
Linux. This CL disables the test on Linux.

TBR=bauerb@chromium.org, jochen@chromium.org
BUG= 663333 
NOTRY=true

Review-Url: https://codereview.chromium.org/2488293002
Cr-Commit-Position: refs/heads/master@{#431267}

[modify] https://crrev.com/1e377a797a25fc281e1fe818b1cb77576e2e8e46/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c6423fb4576679a36f1dbbf547e13fb37eafee2

commit 3c6423fb4576679a36f1dbbf547e13fb37eafee2
Author: jochen <jochen@chromium.org>
Date: Sat Nov 12 22:23:44 2016

Wait for history backend in popup blocker test

BUG= 663333 
R=avi@chromium.org

Review-Url: https://codereview.chromium.org/2495053003
Cr-Commit-Position: refs/heads/master@{#431794}

[modify] https://crrev.com/3c6423fb4576679a36f1dbbf547e13fb37eafee2/chrome/browser/BUILD.gn
[modify] https://crrev.com/3c6423fb4576679a36f1dbbf547e13fb37eafee2/chrome/browser/history/history_browsertest.cc
[add] https://crrev.com/3c6423fb4576679a36f1dbbf547e13fb37eafee2/chrome/browser/history/history_test_utils.cc
[add] https://crrev.com/3c6423fb4576679a36f1dbbf547e13fb37eafee2/chrome/browser/history/history_test_utils.h
[modify] https://crrev.com/3c6423fb4576679a36f1dbbf547e13fb37eafee2/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

This just failed again: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/48929

Reopening to take another look.

Created a CL to disable the test.
https://codereview.chromium.org/2501873002/

Manually landed as https://crrev.com/378fc3fd49ebb678fc98cd99831b858fd304691f

Scott, with the help of the find-it tool, we figured out that this test became flaky when you create the new test target for browser side navigations, i.e., it only fails as browser_side_navigation_interactive_ui_tests but not as interactive_ui_tests

Any idea what's going on here?

In case it helps further analysis, I copied the finding as below:

1. Rerun at r430152 (interactive_ui_tests --> browser_side_navigation_interactive_ui_tests) failed 226 out of 300. (failure reason is "popup_blocker_browsertest.cc:353: Failure", same as the failure in this bug)
2. Rerun at r430151 (still in interactive_ui_tests) failed 6 out of 300. (failure reason is test TIMEOUT)
3. Rerun at r426878 (browser_tests --> interactive_ui_tests) failed 10 out of 300. (failure reason is test TIMEOUT)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dfb2037ddbed4665f325fa0858e76ae83418415

commit 2dfb2037ddbed4665f325fa0858e76ae83418415
Author: jochen <jochen@chromium.org>
Date: Wed Mar 22 08:29:37 2017

Attempt to de-flake popup blocker test for PlzNavigate

BUG= 663333 
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2764943003
Cr-Commit-Position: refs/heads/master@{#458686}

[modify] https://crrev.com/2dfb2037ddbed4665f325fa0858e76ae83418415/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc