New issue
Advanced search Search tips

Issue 663328 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 663324
issue v8:5633



Sign in to add a comment

Difference between fullcode and ignition_staging_turbo_opt: --turbo-escape (Deoptimizer doesn't rematerialize the_hole_nan appropriately)

Project Member Reported by machenb...@chromium.org, Nov 8 2016

Issue description

Requires --turbo-escape. Maybe similar to  issue 660379 ?

# Minimized program:
var v1 = {};
function foo() {
  v2 = [,0.1];
  v1 = true;
  return v2;
}
print(foo());
%OptimizeFunctionOnNextCall(foo);
print(foo());


# Compared fullcode with ignition_turbo_opt

# Flags of fullcode:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --turbo-escape --random-seed -1448083249 --nocrankshaft --turbo-filter=~
# Flags of ignition_turbo_opt:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --turbo-escape --random-seed -1448083249 --ignition-staging --turbo --always-opt

Difference:
- ,0.1
+ NaN,0.1

### Start of configuration fullcode:
,0.1
,0.1

### End of configuration fullcode

### Start of configuration ignition_turbo_opt:
,0.1
NaN,0.1

### End of configuration ignition_turbo_opt
 
This is still occurring, so it's not related to  issue 660379 .
Cc: mythria@chromium.org leszeks@chromium.org
Cc: jarin@chromium.org tebbi@chromium.org
Status: Available (was: Untriaged)
I have the strong suspicion that the deoptimizer has a hard time materializing {hole_nan_value} in this case. It seems escape analysis is flushing this out.
Labels: -Pri-1 Pri-2
Lowering priority because it is staged behind --turbo at the moment.
Blocking: v8:5633
Labels: -Pri-2 Arch-All OS-All Pri-1
Owner: bmeu...@chromium.org
Status: Assigned (was: Available)
Summary: Difference between fullcode and ignition_staging_turbo_opt: --turbo-escape (Deoptimizer doesn't rematerialize the_hole_nan appropriately) (was: Difference between fullcode and ignition_staging_turbo_opt: --turbo-escape)
Labels: -Restrict-View-Google v8-foozzie-failure
Cc: -mstarzinger@chromium.org bmeu...@chromium.org
Owner: mstarzinger@chromium.org
Status: Fixed (was: Assigned)
This is similar to  issue 684208  and has been fixed by 7376e12e00b89d7ba476addeb05058147f8dd91d.

Sign in to add a comment