git cl try fails for WebRTC with Access denied error for buildbucket |
|||||
Issue descriptionToday, in WebRTC, when I do git cl try I get: (12:19:52) [adb] # git cl try ERROR: Access denied: User user:henrika@webrtc.org cannot add builds to bucket master.master.tryserver.webrtc It worked yesterday.
,
Nov 8 2016
What's your depot_tools revision? $ cd $(dirname `which gclient`); git rev-parse HEAD What happens if you checkout latest HEAD of depot_tools? If you can help bisect it, it'd appreciated. Otherwise, tell us exactly how you invoke git cl try. At first, I thought https://chromium.googlesource.com/chromium/tools/depot_tools/+/e4f0fe02a97d526b565fc13152436f6f165e05c6 should have fixed your problem.
,
Nov 8 2016
I can reproduce this as well. Here's the requested information: $ git cl try ERROR: Access denied: User user:kjellander@webrtc.org cannot add builds to bucket master.master.tryserver.webrtc $ git cl try -m tryserver.webrtc ERROR: Access denied: User user:kjellander@webrtc.org cannot add builds to bucket master.master.tryserver.webrtc $ cd $(dirname `which gclient`); git rev-parse HEAD 600d9dfd1a3a7a9b1ece14def1850eca4dc3f38d Which seems to be the HEAD according to https://chromium.googlesource.com/chromium/tools/depot_tools/ Notice that when specifying a bot, it works: $ git cl try --bot=linux_compile_rel -m tryserver.webrtc Tried jobs on: Bucket: master.tryserver.webrtc linux_compile_rel: [] To see results here, run: git cl try-results To see results in browser, run: git cl web This sounds very familiar to the previously reported bug 658317 .
,
Nov 8 2016
OK, here is what happened: WebRTC PRESUBMIT.py has GetPreferredTryMasters which returns buckets from cq.cfg as if they were masters. However, 4 months ago i updated buckets in cq.cfg to be actually buckets (ie master.tryserver.x OR luci.try.X) not master names (ie tryserver.x). qyearsley@ recently cleaned up guessing in git cl try code and assumed GetPreferredTryMasters returns master names, hence you get double "master." prefix. Henrik, can GetPreferredTryMasters be removed? git cl try would then just trigger CQ dry run directly. That would resolve this bug.
,
Nov 8 2016
,
Nov 8 2016
and with this CL I can try it: Using 50% similarity for rename/copy detection. Override with --similarity. PRESUBMIT.py | 25 ------------------------- 1 file changed, 25 deletions(-) Upload server: https://codereview.webrtc.org (change with -s/--server) Issue created. URL: https://codereview.webrtc.org/2486743002 (patchset: 1) Uploading base file for PRESUBMIT.py 0:tandrii@andrii:~/s/tmp/webrtc pre$ git cl try scheduled CQ Dry Run on https://codereview.webrtc.org/2486743002
,
Nov 8 2016
Ah, and since I clearly don't have access to CQ dry run, also this change to cq.cfg so more people can run CQ dry run: https://codereview.webrtc.org/2484243002
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/4fcc4d83ea41bc4476d8f5ddc5a03bbe0ef3500f commit 4fcc4d83ea41bc4476d8f5ddc5a03bbe0ef3500f Author: tandrii <tandrii@chromium.org> Date: Tue Nov 08 13:51:13 2016 Expand CQ dry run permission to people with tryjob access. The group is project-webrtc-tryjob-access provided by Chrome-Infra-Auth: https://chrome-infra-auth.appspot.com/auth/groups#project-webrtc-tryjob-access NOTRY=true R=kjellander@webrtc.org BUG= chromium:663320 Review-Url: https://codereview.webrtc.org/2484243002 Cr-Commit-Position: refs/heads/master@{#14975} [modify] https://crrev.com/4fcc4d83ea41bc4476d8f5ddc5a03bbe0ef3500f/infra/config/cq.cfg
,
Nov 8 2016
https://codereview.webrtc.org/2489523003/ missed to prefix chromium: for the BUG field so it wasn't posted here. I can confirm it now works: $ git cl try scheduled CQ Dry Run on https://codereview.webrtc.org/2488673002 Thanks tandrii!
,
Nov 8 2016
,
Nov 15 2016
[bulk-edit : please ignore if not applicable] Could you please set the correct milestone for this issue? |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kjellander@chromium.org
, Nov 8 2016Owner: ----
Status: Untriaged (was: Assigned)
Summary: git cl try fails for WebRTC with Access denied error for buildbucket (was: git cl try fails)