New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663319 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Caret in contenteditable node is not moving if this element has pseudoclass :after and has definite style http://codepen.io/piotrazsko/pen/WovJrZ

Reported by piotraz...@gmail.com, Nov 8 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

Steps to reproduce the problem:
1. Set caret to line.
2. Typing.
3. 

What is the expected behavior?
Caret moving before first symbol.

What went wrong?
Caret is stoped.

Did this work before? N/A 

Chrome version: 54.0.2840.87   Channel: n/a
OS Version: 7
Flash Version:
 
This bug reproduced on linux version of Chrome

Comment 2 Deleted

This bug is not reproduce if pseudoclass ":after"  has style:"display:inline-block"
Cc: sureshkumari@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on windows-7, Mac-10.11.6 and linux ubuntu 14.04 using chrome stable version 	54.0.2840.87 and latest canary 56.0.2913.0 with the steps mentioned above.
Please find the attached screen-cast for reference.
Could you please let us know if anything missed here to reproduce the issue.


Thanks..
issue-663319.mp4
446 KB View Download

Comment 5 Deleted

This problem reproduced , if  style of block : {display:table-cell} and in some cases with next style :{display:block}. I added a video to this comment;
1. Cursor position Chrome.mp4
312 KB View Download
In prev and  this video, caret not movie. Caret stoped in begining of line, but text added in ending of line.
Cc: jmukthavaram@chromium.org
Labels: -Type-Bug -Pri-2 -Needs-Feedback M-56 hasbisect OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: wkorman@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on windows 7, Mac 10.11.6,Linux Ubuntu 14.04 with Chrome stable version#54.0.2840.99 and Canary #	56.0.2914.1

Provided Manual Bisect as it is branch bisect:
-----------------------------------------------
Bad Build—54.0.2840.15

Good Build—54.0.2840.14

CL :
-------------------------
https://chromium.googlesource.com/chromium/src/+log/54.0.2840.14..54.0.2840.15?pretty=fuller&n=10000

Review-Url: 

https://codereview.chromium.org/2293293003
-----------
wkorman@ assigning to you, as you were listed as one of the reviewers for this CL.

Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.

Thanks.!
Components: Blink>Paint>Invalidation
This sounds similar to  http://crbug.com/645665  but given it's reproducible with M56 Canary it must be a variant case.

https://codereview.chromium.org/2401363003 for reference.

I will look into this soon.
Attached is reduced test case. To reproduce:
1. click in text field
2. press right arrow.
3. type a character like 'a'. character is entered, but caret ceases to blink. typing add'l chars inputs them but caret stays frozen where it was when it stopped blinking.
caret.html
113 bytes View Download
Just to update, able to reproduce the issue on windows 7 using chrome version 57.0.2931.0 and dev 56.0.2923.4.
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05b6f4be7e2e45c518441e2cf546d4472ee06fcb

commit 05b6f4be7e2e45c518441e2cf546d4472ee06fcb
Author: wkorman <wkorman@chromium.org>
Date: Sun Dec 11 21:30:57 2016

Fix mismatched nullptr check for caret paint invalidation.

We moved to checking need-for-repaint and invalidating based
on anchor node in http://crrev.com/2401363003 but we
incorrectly left null-checking based on non-anchor node.

BUG= 663319 

Review-Url: https://codereview.chromium.org/2565103002
Cr-Commit-Position: refs/heads/master@{#437804}

[add] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/LayoutTests/paint/invalidation/caret-contenteditable-content-after.html
[add] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/caret-contenteditable-content-after-expected.png
[add] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/caret-contenteditable-content-after-expected.txt
[add] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.png
[add] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.txt
[add] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/caret-contenteditable-content-after-expected.png
[add] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/caret-contenteditable-content-after-expected.txt
[add] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.png
[add] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.txt
[add] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/caret-contenteditable-content-after-expected.png
[add] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/caret-contenteditable-content-after-expected.txt
[add] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.png
[add] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/caret-contenteditable-content-after-expected.txt
[modify] https://crrev.com/05b6f4be7e2e45c518441e2cf546d4472ee06fcb/third_party/WebKit/Source/core/editing/FrameCaret.cpp

Status: Fixed (was: Assigned)
Tested original codepen on Win7 57.0.2949.0 canary (64-bit) which includes the above change and it is fixed for me.

Sign in to add a comment