RequestCoordinatorTest.PauseAndResumeObserver is flaky on IOS |
|||||
Issue descriptionFrom 658619 Detected 5 new flakes for test/step "components_unittests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRjb21wb25lbnRzX3VuaXR0ZXN0cww. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f0ee880ebc26f7ed7819c2d6e412d8645fd66ed commit 3f0ee880ebc26f7ed7819c2d6e412d8645fd66ed Author: perkj <perkj@chromium.org> Date: Tue Nov 08 11:30:01 2016 Disable RequestCoordinatorTest.PauseAndResumeObserver on IOS BUG= 663311 TBR=petewil@chromium.org Review-Url: https://codereview.chromium.org/2486653003 Cr-Commit-Position: refs/heads/master@{#430577} [modify] https://crrev.com/3f0ee880ebc26f7ed7819c2d6e412d8645fd66ed/components/offline_pages/background/request_coordinator_unittest.cc
,
Nov 10 2016
Looks like DownloadNotifyingObserver is not used on iOS. Sylvain, do you know if we have a process for figuring out what should be and what should not be a part of Chrome for iOS binary?
,
Nov 10 2016
I am the right owner for this. This code should be android only, at least for now. Once I figure out how, I plan to stop it compiling on iOS.
,
Nov 10 2016
(Correction, petewil@chromium.org is the right owner, not petewil@google.com)
,
Nov 14 2016
Re #3, there is no formal process to figure out what is required by Chrome on iOS. If you have access to the downstream Chrome on iOS repository, you can check whether the code is used by iOS. Once Chrome on iOS code is open-sourced, then all the dependencies will be visible upstream and the answer will be just look at the dependencies of chrome target when target_os="ios". If the test is testing code that is never used on iOS, the easiest thing is to just remove it from components_unittests if "is_ios" is true.
,
Nov 14 2016
,
Jan 25 2017
,
Feb 28 2017
This is a good fixit hotlist bug. Work here is to find out why the test is running on iOS and disable it there (possibly disabling other irrelevant tests).
,
Apr 14 2017
In src/components/BUILD.gn, I can move the offline pages tests into the if !iOS section (actually an else about line 174.
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1d20c2c1eaf66e21152653b62c285fcebd2f6f9 commit a1d20c2c1eaf66e21152653b62c285fcebd2f6f9 Author: petewil <petewil@chromium.org> Date: Tue Apr 25 16:55:41 2017 Disable offline pages tests on iOS Since we won't be able to run on iOS without major work (we require blink), I'm disabling our unit tests there for now. They can be easily re-enabled by reverting this change. BUG= 663311 Review-Url: https://codereview.chromium.org/2839723002 Cr-Commit-Position: refs/heads/master@{#467019} [modify] https://crrev.com/a1d20c2c1eaf66e21152653b62c285fcebd2f6f9/components/BUILD.gn [modify] https://crrev.com/a1d20c2c1eaf66e21152653b62c285fcebd2f6f9/components/offline_pages/core/background/request_coordinator_unittest.cc
,
Apr 28 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by perkj@chromium.org
, Nov 8 2016