Regression:Unnecessary 'Backspace shortcut' bubble is seen for every second backspace key hit /click for editable pdf.
Reported by
dmascare...@etouch.net,
Nov 8 2016
|
||||||
Issue descriptionChrome Version:56.0.2912.0 (Official Build) 817f8b49ade74a199d0c83d11a7befb89e1a0ba5-refs/heads/master@{#430205} OS: Windows(7,8,10), Mac(10.10.5,10.11.4),Linux(14.04 LTS) Test url: http://www.thewebjockeys.com/TheWebJockeys/Fillable_PDF_Sample_from_TheWebJockeys_vC5.pdf What steps will reproduce the problem? 1. Launch chrome and navigate to test url. 2. Enter some text in text field and then press 'Backspace' key twice, observe. Actual:Unnecessary 'Backspace shortcut' bubble is seen for every second backspace key hit /click. Expected: 'Backspace shortcut' bubble should not be seen when focus is in text field of pdf. This is regression issue, broken in 'M 55' and below is manual bisect: Good build:55.0.2844.0 Bad build:55.0.2845.0
,
Nov 8 2016
,
Nov 8 2016
,
Nov 9 2016
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium.git/+/7b3252fa1f282c01707fc53d0ac347878dd0aebb commit 7b3252fa1f282c01707fc53d0ac347878dd0aebb Author: thestig <thestig@chromium.org> Date: Wed Nov 09 05:30:11 2016 Fix regression in annotation key event handling. BUG= chromium:663294 Review-Url: https://codereview.chromium.org/2482143002 [modify] https://crrev.com/7b3252fa1f282c01707fc53d0ac347878dd0aebb/fpdfsdk/cpdfsdk_annothandlermgr.cpp
,
Nov 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30211ed177975458a72e8faf271b6e5463b2d2d0 commit 30211ed177975458a72e8faf271b6e5463b2d2d0 Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org> Date: Wed Nov 09 06:38:53 2016 Roll src/third_party/pdfium/ d0ecd899d..7b3252fa1 (1 commit). https://pdfium.googlesource.com/pdfium.git/+log/d0ecd899d632..7b3252fa1f28 $ git log d0ecd899d..7b3252fa1 --date=short --no-merges --format='%ad %ae %s' 2016-11-08 thestig Fix regression in annotation key event handling. BUG= 663294 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2486133002 Cr-Commit-Position: refs/heads/master@{#430879} [modify] https://crrev.com/30211ed177975458a72e8faf271b6e5463b2d2d0/DEPS
,
Nov 9 2016
Rechecked this on chrome version 56.0.2914.0 on Win 10, MAC 10.12.1 and Ubuntu 14.04. Fix is working as intended. No bubble is seen for every second backspace entry. Adding TE-Verified labels. Can we have a merge of this issue to M55 branch as issue is broken in M55 with a stable blocker. M55 is approaching Stable soon. Thanks.!
,
Nov 9 2016
Thank you for verifying on Canary. Requesting merge.
,
Nov 9 2016
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.
,
Nov 10 2016
Approving merge to M55 branch 2883 based on comment #6 and #7. Please merge ASAP. Thank you.
,
Nov 10 2016
https://chromereviews.googleplex.com/539117013 out for review to merge.
,
Nov 10 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by msrchandra@chromium.org
, Nov 8 2016Labels: ReleaseBlock-Stable hasbisect-per-revision
Owner: dsinclair@chromium.org
Status: Assigned (was: Unconfirmed)