New issue
Advanced search Search tips

Issue 663263 link

Starred by 1 user
Status: Verified
Owner:
fgor...@chromium.org
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

"RELOAD" snack bar is not displaying for offline pages

Project Member Reported by kgna...@chromium.org, Nov 8 2016 
Application Version (from "Chrome Settings > About Chrome"): 56.0.2913.0
Android Build Number (from "Android Settings > About Phone/Tablet"): NMF26H
Device: Nexus 6P

Steps to reproduce: 
1.Launch chrome
2.Open any page and tap on download button from menu for offline page to be dowloaded 
3.Go to downloads and tap on the dowloaded file 

Observed behavior: 
"RELOAD" snack bar not displayed 

Expected behavior: 
"Viewing an offline copy of this page RELOAD" snack bar should be displayed

Frequency: 
<number of times you were able to reproduce> 

Additional comments:

Comment 2 by kgna...@chromium.org, Nov 8 2016 

fgorski@, Can you please look in to this issue, Thanks!

Please find logs and screen record @ http://go/chrome-androidlogs1/6/663263

Comment 3 by fgor...@chromium.org, Nov 8 2016

Labels: -Restrict-View-Google -ReleaseBlock-Stable

Comment 4 by fgor...@chromium.org, Nov 19 2016

Status: Started (was: Assigned)
https://codereview.chromium.org/2520583002/
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7c13b94eafad8d7458bde05ca6733eb11d731be

commit b7c13b94eafad8d7458bde05ca6733eb11d731be
Author: fgorski <fgorski@chromium.org>
Date: Mon Nov 21 23:51:35 2016

[Offline pages] Addressing several reload snackbar issues

* Solves the problem of snackbar not working after incognito tabs being
  dismissed
* solves the problem of snackbar not working when there is a download
  happening in between.

BUG= 663263 ,662353, 660577 

Review-Url: https://codereview.chromium.org/2520583002
Cr-Commit-Position: refs/heads/master@{#433700}

[modify] https://crrev.com/b7c13b94eafad8d7458bde05ca6733eb11d731be/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
[modify] https://crrev.com/b7c13b94eafad8d7458bde05ca6733eb11d731be/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 22 2016

Labels: merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7cde35af699b567f1cd88ffbebd3b12623f133f

commit d7cde35af699b567f1cd88ffbebd3b12623f133f
Author: Filip Gorski <fgorski@chromium.org>
Date: Tue Nov 22 18:09:18 2016

[Offline pages] Addressing several reload snackbar issues

* Solves the problem of snackbar not working after incognito tabs being
  dismissed
* solves the problem of snackbar not working when there is a download
  happening in between.

BUG= 663263 ,662353, 660577 

Review-Url: https://codereview.chromium.org/2520583002
Cr-Commit-Position: refs/heads/master@{#433700}
(cherry picked from commit b7c13b94eafad8d7458bde05ca6733eb11d731be)

Review URL: https://codereview.chromium.org/2529433002 .

Cr-Commit-Position: refs/branch-heads/2924@{#59}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/d7cde35af699b567f1cd88ffbebd3b12623f133f/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
[modify] https://crrev.com/d7cde35af699b567f1cd88ffbebd3b12623f133f/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

Comment 7 by fgor...@chromium.org, Nov 22 2016

Status: Fixed (was: Started)

Comment 8 by kgna...@chromium.org, Nov 29 2016

Status: Verified (was: Fixed)
Works as per expected behavior, issue fixed on 56.0.2924.10
►

Sign in to add a comment