New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663247 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 543161



Sign in to add a comment

Ignore full hash response for stores that the database isn't interested in.

Project Member Reported by vakh@chromium.org, Nov 8 2016

Issue description

V4GetHashProtocolManager::ParseHashResponse currently caches FullHashInfo objects for all valid list identifiers. This can be different from the lists that the database is currently checking.

Caching FullHashInfos for lists that the database isn't tracking is wasteful since the V4LocalDatabaseManager would never ask for those FullHashInfo objects.

Solution: If the list for which we received the response is not one that we are currently tracking, ignore that ListUpdateResponse.
 

Comment 1 by vakh@chromium.org, Nov 8 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfcde5d0640845a210555226cd7de95cb5bb63b4

commit bfcde5d0640845a210555226cd7de95cb5bb63b4
Author: vakh <vakh@chromium.org>
Date: Thu Nov 10 01:44:15 2016

Ignore ThreatMatch responses for lists that we don't care about.

Due to aliasing used on the server side, the server may send ThreatMatch
response for lists that we don't track. For instance, ThreatMatch with
platform_type as CHROME on Linux. Ignore such ThreatMatch responses.

BUG= 663247 

Review-Url: https://codereview.chromium.org/2490753002
Cr-Commit-Position: refs/heads/master@{#431131}

[modify] https://crrev.com/bfcde5d0640845a210555226cd7de95cb5bb63b4/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
[modify] https://crrev.com/bfcde5d0640845a210555226cd7de95cb5bb63b4/components/safe_browsing_db/v4_get_hash_protocol_manager.h
[modify] https://crrev.com/bfcde5d0640845a210555226cd7de95cb5bb63b4/components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc

Comment 3 by vakh@chromium.org, Nov 15 2016

Status: Fixed (was: Started)

Sign in to add a comment