New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663245 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 9
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add gantt chart to build status pages

Project Member Reported by philwright@chromium.org, Nov 8 2016

Issue description

Add a gantt chart to build status pages to show timing of various steps
 
First submission in codereview.chromium.org/2484593002

Some enhancements still needed
 - add to milo UI
 - get 'real' times for swarming tasks (currently each "collect" step has an end time that is monotonically increasing from the previous step because steps are executed serially
 - Add per-shard durations
More enhancement
 - make color reflect status
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/f128e42562e0a67c111394c5f398ef9b1d93b6bd

commit f128e42562e0a67c111394c5f398ef9b1d93b6bd
Author: philwright <philwright@google.com>
Date: Wed Nov 09 06:08:58 2016

Adding gantt chart to Build Status page on Buildbot Masters

Screenshots:
Initial page load - https://screenshot.googleplex.com/NJjHFTcXU9T.png
After button clicked - https://screenshot.googleplex.com/QHn0DLd0Jv9.png

BUG= 663245 
TEST=local
 - ran local buildbot, generated screenshots

Review-Url: https://codereview.chromium.org/2484593002

[add] https://crrev.com/f128e42562e0a67c111394c5f398ef9b1d93b6bd/masters/master.chromium.infra.codesearch/public_html/gantt_chart.js
[add] https://crrev.com/f128e42562e0a67c111394c5f398ef9b1d93b6bd/masters/master.chromium.infra/public_html/gantt_chart.js
[modify] https://crrev.com/f128e42562e0a67c111394c5f398ef9b1d93b6bd/masters/master.chromium.perf.fyi/templates/build.html
[add] https://crrev.com/f128e42562e0a67c111394c5f398ef9b1d93b6bd/masters/master.chromium/public_html/gantt_chart.js
[modify] https://crrev.com/f128e42562e0a67c111394c5f398ef9b1d93b6bd/masters/master.chromium/templates/build.html
[add] https://crrev.com/f128e42562e0a67c111394c5f398ef9b1d93b6bd/masters/master.chromiumos/public_html/gantt_chart.js
[modify] https://crrev.com/f128e42562e0a67c111394c5f398ef9b1d93b6bd/masters/master.chromiumos/templates/build.html
[modify] https://crrev.com/f128e42562e0a67c111394c5f398ef9b1d93b6bd/masters/master.tryserver.blink/templates/build.html
[add] https://crrev.com/f128e42562e0a67c111394c5f398ef9b1d93b6bd/masters/master.tryserver.chromium.linux/public_html/gantt_chart.js
[modify] https://crrev.com/f128e42562e0a67c111394c5f398ef9b1d93b6bd/masters/master.tryserver.chromium.linux/templates/build.html
[modify] https://crrev.com/f128e42562e0a67c111394c5f398ef9b1d93b6bd/masters/master.tryserver.chromium.perf/templates/build.html

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/2fe427b9a0281ba645cab0a53d999545d70c887d

commit 2fe427b9a0281ba645cab0a53d999545d70c887d
Author: machenbach <machenbach@chromium.org>
Date: Wed Nov 09 10:52:09 2016

Revert of Adding gantt chart to Build Status page on Buildbot Masters (patchset #13 id:240001 of https://codereview.chromium.org/2484593002/ )

Reason for revert:
This fails on all masters the moment we sync. Now, master1 was synced after a restart of chromium.fyi and this change became life on all masters of master1. Log says:
	  File "../master.chromium/templates/build.html", line 12, in template
	    {'name': '{{ s.getName()|escapejs }}',
	jinja2.exceptions.TemplateAssertionError: no filter named 'escapejs'

Original issue's description:
> Adding gantt chart to Build Status page on Buildbot Masters
>
> Screenshots:
> Initial page load - https://screenshot.googleplex.com/NJjHFTcXU9T.png
> After button clicked - https://screenshot.googleplex.com/QHn0DLd0Jv9.png
>
> BUG= 663245 
> TEST=local
>  - ran local buildbot, generated screenshots
>
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/f128e42562e0a67c111394c5f398ef9b1d93b6bd

TBR=tansell@chromium.org,dsansome@chromium.org,estaab@chromium.org,iannucci@chromium.org,martiniss@chromium.org,sergiyb@chromium.org,philwright@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 663245 

Review-Url: https://codereview.chromium.org/2489813002

[delete] https://crrev.com/befc2a20db077705cd3036dd2407b10abb730425/masters/master.chromium.infra.codesearch/public_html/gantt_chart.js
[delete] https://crrev.com/befc2a20db077705cd3036dd2407b10abb730425/masters/master.chromium.infra/public_html/gantt_chart.js
[modify] https://crrev.com/2fe427b9a0281ba645cab0a53d999545d70c887d/masters/master.chromium.perf.fyi/templates/build.html
[delete] https://crrev.com/befc2a20db077705cd3036dd2407b10abb730425/masters/master.chromium/public_html/gantt_chart.js
[modify] https://crrev.com/2fe427b9a0281ba645cab0a53d999545d70c887d/masters/master.chromium/templates/build.html
[delete] https://crrev.com/befc2a20db077705cd3036dd2407b10abb730425/masters/master.chromiumos/public_html/gantt_chart.js
[modify] https://crrev.com/2fe427b9a0281ba645cab0a53d999545d70c887d/masters/master.chromiumos/templates/build.html
[modify] https://crrev.com/2fe427b9a0281ba645cab0a53d999545d70c887d/masters/master.tryserver.blink/templates/build.html
[delete] https://crrev.com/befc2a20db077705cd3036dd2407b10abb730425/masters/master.tryserver.chromium.linux/public_html/gantt_chart.js
[modify] https://crrev.com/2fe427b9a0281ba645cab0a53d999545d70c887d/masters/master.tryserver.chromium.linux/templates/build.html
[modify] https://crrev.com/2fe427b9a0281ba645cab0a53d999545d70c887d/masters/master.tryserver.chromium.perf/templates/build.html

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/a7c23abe68874fe23ff38ba34ed782aca9cd1559

commit a7c23abe68874fe23ff38ba34ed782aca9cd1559
Author: philwright <philwright@google.com>
Date: Wed Nov 16 04:52:41 2016

adding ability to restart all masters

BUG= 663245 

Change-Id: I76560e57e5c71dc5ae0c7a306b95f27c315b7e45
Reviewed-on: https://chromium-review.googlesource.com/411293
Commit-Queue: Phil Wright <philwright@chromium.org>
Reviewed-by: Dave Sansome <dsansome@chromium.org>

[modify] https://crrev.com/a7c23abe68874fe23ff38ba34ed782aca9cd1559/infra/tools/restart/__main__.py
[modify] https://crrev.com/a7c23abe68874fe23ff38ba34ed782aca9cd1559/infra/tools/restart/restart.py

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/34eea10c63569f86d2b83889b71a1b2f8335033b

commit 34eea10c63569f86d2b83889b71a1b2f8335033b
Author: philwright <philwright@google.com>
Date: Mon Nov 21 22:24:05 2016

Adding gantt chart to Build Status page on Buildbot Masters

This is second attempt at commit
f128e42562e0a67c111394c5f398ef9b1d93b6bd, which was reverted.

Screenshots:
Initial page load - https://screenshot.googleplex.com/NJjHFTcXU9T.png
After button clicked - https://screenshot.googleplex.com/QHn0DLd0Jv9.png

BUG= 663245 
TEST=local
 - ran local buildbot, generated screenshots

Change-Id: I1c0c08b29de5353d25324095f82dd733b58f94fc
Review-Url: https://codereview.chromium.org/2484593002
Reviewed-on: https://chromium-review.googlesource.com/412542
Commit-Queue: Phil Wright <philwright@chromium.org>
Reviewed-by: Dave Sansome <dsansome@chromium.org>

[add] https://crrev.com/34eea10c63569f86d2b83889b71a1b2f8335033b/masters/master.chromium.infra.codesearch/public_html/gantt_chart.js
[add] https://crrev.com/34eea10c63569f86d2b83889b71a1b2f8335033b/masters/master.chromium.infra/public_html/gantt_chart.js
[modify] https://crrev.com/34eea10c63569f86d2b83889b71a1b2f8335033b/masters/master.chromium.perf.fyi/templates/build.html
[add] https://crrev.com/34eea10c63569f86d2b83889b71a1b2f8335033b/masters/master.chromium/public_html/gantt_chart.js
[modify] https://crrev.com/34eea10c63569f86d2b83889b71a1b2f8335033b/masters/master.chromium/templates/build.html
[add] https://crrev.com/34eea10c63569f86d2b83889b71a1b2f8335033b/masters/master.chromiumos/public_html/gantt_chart.js
[modify] https://crrev.com/34eea10c63569f86d2b83889b71a1b2f8335033b/masters/master.chromiumos/templates/build.html
[modify] https://crrev.com/34eea10c63569f86d2b83889b71a1b2f8335033b/masters/master.tryserver.blink/templates/build.html
[add] https://crrev.com/34eea10c63569f86d2b83889b71a1b2f8335033b/masters/master.tryserver.chromium.linux/public_html/gantt_chart.js
[modify] https://crrev.com/34eea10c63569f86d2b83889b71a1b2f8335033b/masters/master.tryserver.chromium.linux/templates/build.html
[modify] https://crrev.com/34eea10c63569f86d2b83889b71a1b2f8335033b/masters/master.tryserver.chromium.perf/templates/build.html

Status: WontFix (was: Assigned)
Stale bugs - closing

Sign in to add a comment