Abort EWInstance::Start during shutting down |
||
Issue descriptionIssue 658702 showed that EWInstance::Start could be called while shutting down and that was possible to be a cause of the crash because a mojo error handler is bound to the UI thread in that situation. Currently the error handler worked around the crash just by skipping the handler, but the correct way is not to start the worker when shutting down.
,
Jan 9
shimazu: Can you comment on whether this bug is still relevant? I also don't really understand why the workaround isn't sufficient, seems it should be fine to call Start() as long as the browser shutdown proceeds normally without crashing.
,
Jan 10
Actually the original workaround has gone since https://crbug.com/604762 has fixed. This issue is to improve the shutdown procedure. When I created this issue, I thought the restart logic should not be triggered during shutdown since it adds more work to the shutdown procedure. I'm okay to close this if you think it's not a problem.
,
Jan 10
Thanks. I think it's fine, it likely doesn't block shutdown in a perceptible way. The restart sequence is causing a bit of complexity though, I'm thinking we should probably post task to do the restart instead of synchronously in OnStopped. Can be another CL/bug. |
||
►
Sign in to add a comment |
||
Comment 1 by shimazu@chromium.org
, Nov 8 2016