Issue metadata
Sign in to add a comment
|
Throttle the rendering pipeline during page load when there's pending sheets. |
||||||||||||||||||||||||||||||||||||||||
Issue descriptionChange description: Throttle the rendering pipeline during page load when there's pending sheets. Changes to API surface: requestAnimationFrame won't run for iframes with pending sheets until they start painting. We already do this for the top level document. Note that the frames wouldn't normally paint previously, but *did* confusingly run raf even though nothing showed up. See design doc: (Whole doc is relevant, but the linked section in particular describes this step.) https://docs.google.com/document/d/1waQggCtPb44gwTp8PK5iz4B-YTiSOSBqbqtbopNrxNA/edit#bookmark=id.nd4ci4rhu9b1 Support in other browsers: Internet Explorer: None Firefox: None Safari: None All browsers disagree today about how to avoid FOUC, this is a huge simplification to our design.
,
Nov 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1489b47d07ee66f530d0bb99fff53e0cdd84c8dd commit 1489b47d07ee66f530d0bb99fff53e0cdd84c8dd Author: esprehn <esprehn@chromium.org> Date: Wed Nov 09 00:33:49 2016 Turn on render throttling for iframes with pending sheets. This prevents us from doing layout, style, paint and requestAnimationFrame for frames that are waiting on pending stylesheets and are not actually painting. This puts the feature behind the --experimental-web-platform-features flag pending approval of the Intent to Ship. BUG= 663193 , 521692 Review-Url: https://codereview.chromium.org/2401713003 Cr-Commit-Position: refs/heads/master@{#430794} [modify] https://crrev.com/1489b47d07ee66f530d0bb99fff53e0cdd84c8dd/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/1489b47d07ee66f530d0bb99fff53e0cdd84c8dd/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/1489b47d07ee66f530d0bb99fff53e0cdd84c8dd/third_party/WebKit/Source/core/frame/FrameView.h [modify] https://crrev.com/1489b47d07ee66f530d0bb99fff53e0cdd84c8dd/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in [modify] https://crrev.com/1489b47d07ee66f530d0bb99fff53e0cdd84c8dd/third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp
,
Nov 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6c90470f20ec3d83f0f8b95c2943885c1b0f69a commit e6c90470f20ec3d83f0f8b95c2943885c1b0f69a Author: esprehn <esprehn@chromium.org> Date: Sat Nov 12 01:33:53 2016 Ship pipeline throttling for iframes with loading sheets. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/8Wd46miNvDc/Tf6yXtkQAQAJ BUG= 663193 Review-Url: https://codereview.chromium.org/2488213005 Cr-Commit-Position: refs/heads/master@{#431729} [modify] https://crrev.com/e6c90470f20ec3d83f0f8b95c2943885c1b0f69a/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
,
Nov 18 2016
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/606b90f2399152dc70dad8c7592b34465b4b13f3 commit 606b90f2399152dc70dad8c7592b34465b4b13f3 Author: Eric Willigers <ericwilligers@chromium.org> Date: Fri Aug 10 03:57:36 2018 Retire rendering pipeline throttling runtime flag Pipeline throttling for iframes with loading sheets shipped in M56 https://codereview.chromium.org/2488213005 https://www.chromestatus.com/feature/5640551701413888 The flag RenderingPipelineThrottlingLoadingIframes is no longer needed. BUG= 663193 Change-Id: Ieba672a8f7a8e3e0702a182aacf9931fec54a3d9 Reviewed-on: https://chromium-review.googlesource.com/1166747 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582043} [modify] https://crrev.com/606b90f2399152dc70dad8c7592b34465b4b13f3/third_party/blink/renderer/core/frame/local_frame_view.cc [modify] https://crrev.com/606b90f2399152dc70dad8c7592b34465b4b13f3/third_party/blink/renderer/platform/runtime_enabled_features.json5 |
|||||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||||||||
Comment 1 by esprehn@chromium.org
, Nov 8 2016