New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663155 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 626200



Sign in to add a comment

6.2%-44.7% regression in smoothness.key_desktop_move_cases at 429772:429833

Project Member Reported by briander...@chromium.org, Nov 8 2016

Issue description

See the link to graphs below.
 
Cc: flackr@chromium.org
Owner: flackr@chromium.org

=== Auto-CCing suspected CL author flackr@chromium.org ===

Hi flackr@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Enable compositing opaque fixed position elements which will maintain LCD text.
Author  : flackr
Commit description:
  
BUG= 661754 

Review-Url: https://codereview.chromium.org/2468323002
Cr-Commit-Position: refs/heads/master@{#429804}
Commit  : 5516863851ccc8158564461bb1c15af7f16436ac
Date    : Fri Nov 04 06:02:02 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N  Good?
chromium@429803  17.0128  0.570266  6  good
chromium@429804  23.7509  0.209034  4  bad    <--
chromium@429805  23.6253  0.157591  5  bad
chromium@429806  23.6462  0.163778  5  bad
chromium@429809  23.9635  0.263379  5  bad

Bisect job ran on: win_8_perf_bisect
Bug ID: 663155

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests smoothness.key_desktop_move_cases
Test Metric: mean_input_event_latency/mean_input_event_latency
Relative Change: 43.00%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/2274
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8996606633091606448


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5320913824776192

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: ssid@chromium.org
+ssid, test owner.

@flacker: Was the regression in frame_times and latency expected for key_desktop_move cases?

Comment 5 by enne@chromium.org, Nov 10 2016

Status: Assigned (was: Untriaged)

Comment 6 by flackr@chromium.org, Feb 22 2017

Blocking: 626200
Labels: -M-56 Hotlist-ThreadedRendering
The original CL was reverted and the graph returned to normal. I'll mark this as blocking re-enabling.

Comment 7 by flackr@chromium.org, Apr 25 2017

Labels: -Type-Bug-Regression Type-Task
Changing type as this is not a current bug / regression, but needs to be tracked when relanding 5516863851ccc8158564461bb1c15af7f16436ac

Comment 8 by flackr@chromium.org, Jun 22 2017

It looks like gmail has changed a lot since this recording. In the recorded version they have several full-screen opaque fixed position elements. On low dpi these didn't used to be promoted but when promoted they cause promotion of several of the e-mail elements during the scroll due to overlap.

I think we should update the recording so that the test is representative of the current real world experience.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d097cf30a2dee37de4586de97f06269ed03da09

commit 8d097cf30a2dee37de4586de97f06269ed03da09
Author: Robert Flack <flackr@chromium.org>
Date: Fri Jun 30 16:42:01 2017

Update google_login helper and gmail recordings.

Support old and new google login fields. Update the gmail recordings used for
smoothness metrics. Removes the old custom login behavior in GmailSmoothPage.

Bug:  590766 , 663155 
Change-Id: I7c6d22b48e7cb16501dc393564d7e4df097490db
Reviewed-on: https://chromium-review.googlesource.com/546615
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483732}
[modify] https://crrev.com/8d097cf30a2dee37de4586de97f06269ed03da09/tools/perf/page_sets/data/key_desktop_move_cases.json
[add] https://crrev.com/8d097cf30a2dee37de4586de97f06269ed03da09/tools/perf/page_sets/data/key_desktop_move_cases_002.wpr.sha1
[add] https://crrev.com/8d097cf30a2dee37de4586de97f06269ed03da09/tools/perf/page_sets/data/top_25_006.wpr.sha1
[modify] https://crrev.com/8d097cf30a2dee37de4586de97f06269ed03da09/tools/perf/page_sets/data/top_25_smooth.json
[modify] https://crrev.com/8d097cf30a2dee37de4586de97f06269ed03da09/tools/perf/page_sets/key_desktop_move_cases.py
[modify] https://crrev.com/8d097cf30a2dee37de4586de97f06269ed03da09/tools/perf/page_sets/login_helpers/google_login.py
[modify] https://crrev.com/8d097cf30a2dee37de4586de97f06269ed03da09/tools/perf/page_sets/top_25_smooth.py
[modify] https://crrev.com/8d097cf30a2dee37de4586de97f06269ed03da09/tools/perf/page_sets/top_pages.py

Status: Fixed (was: Assigned)
With the up to date recording, we should no longer see the spike when enabling compositing opaque fixed position. While the old site regressing may be concerning, it's worth noting that fixed position promotion is default on high DPI devices, so they would have always had the slower performance.

Sign in to add a comment