New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 663126 link

Starred by 1 user
Status: Fixed
Owner:
█ jbau...@chromium.org
not on Chrome anymore
Closed: Dec 2016
Cc:
█ kbr@chromium.org
posciak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Run video_decode_accelerator_unittest on GPU bots.

Project Member Reported by jbau...@chromium.org, Nov 7 2016 
Currently it's broken on windows, but once that's fixed it'd be nice to make sure it doesn't regress.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/483691c8c1de73ba6bc9ffac4f7b311c87a42c23

commit 483691c8c1de73ba6bc9ffac4f7b311c87a42c23
Author: jbauman <jbauman@chromium.org>
Date: Thu Dec 15 08:02:41 2016

Allow video_decode_accelerator_unittest to be run in an isolate.

The main change is to use base::LaunchUnitTestsSerially as a test runner
so it can parse some command-line arguments the isolate test runner
passes in.

BUG= 663126 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2521793002
Cr-Commit-Position: refs/heads/master@{#438779}

[modify] https://crrev.com/483691c8c1de73ba6bc9ffac4f7b311c87a42c23/media/gpu/BUILD.gn
[modify] https://crrev.com/483691c8c1de73ba6bc9ffac4f7b311c87a42c23/media/gpu/video_decode_accelerator_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a6c4a16e1fb4e94306619aef9847ca394e1cb0e

commit 0a6c4a16e1fb4e94306619aef9847ca394e1cb0e
Author: jbauman <jbauman@chromium.org>
Date: Mon Dec 19 23:41:23 2016

Run video_decode_accelerator_unittest on windows GPU bots.

This tests our hardware video decoding path.

BUG= 663126 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2578793003
Cr-Commit-Position: refs/heads/master@{#439614}

[modify] https://crrev.com/0a6c4a16e1fb4e94306619aef9847ca394e1cb0e/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/0a6c4a16e1fb4e94306619aef9847ca394e1cb0e/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/0a6c4a16e1fb4e94306619aef9847ca394e1cb0e/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/0a6c4a16e1fb4e94306619aef9847ca394e1cb0e/testing/buildbot/gn_isolate_map.pyl

Comment 3 by jbau...@chromium.org, Dec 20 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb22e9c7a95045446775bfca936024596222ce8b

commit bb22e9c7a95045446775bfca936024596222ce8b
Author: jbauman <jbauman@chromium.org>
Date: Thu Dec 22 01:35:29 2016

Revert of Run video_decode_accelerator_unittest on windows GPU bots.

Reason for revert:
The test can't find the video test file on some FYI bots.

Original issue's description
> This tests our hardware video decoding path.

> BUG= 663126 
> Cr-Commit-Position: refs/heads/master@{#439614}

BUG= 676053 , 663126 
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2592283002
Cr-Commit-Position: refs/heads/master@{#440303}

[modify] https://crrev.com/bb22e9c7a95045446775bfca936024596222ce8b/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/bb22e9c7a95045446775bfca936024596222ce8b/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/bb22e9c7a95045446775bfca936024596222ce8b/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/bb22e9c7a95045446775bfca936024596222ce8b/testing/buildbot/gn_isolate_map.pyl
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d69f117b2cc60f748e75ea72f33abc346d850a10

commit d69f117b2cc60f748e75ea72f33abc346d850a10
Author: jbauman <jbauman@chromium.org>
Date: Tue Jan 10 01:46:49 2017

Reland of Run video_decode_accelerator_unittest on windows GPU bots.

This tests our hardware video decoding path.

BUG= 663126 , 676053 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2617263002
Cr-Commit-Position: refs/heads/master@{#442445}

[modify] https://crrev.com/d69f117b2cc60f748e75ea72f33abc346d850a10/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/d69f117b2cc60f748e75ea72f33abc346d850a10/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/d69f117b2cc60f748e75ea72f33abc346d850a10/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/d69f117b2cc60f748e75ea72f33abc346d850a10/testing/buildbot/gn_isolate_map.pyl
►

Sign in to add a comment