New issue
Advanced search Search tips

Issue 663110 link

Starred by 1 user
Status: Fixed
Owner:
jbudorick@chromium.org
Closed: Nov 2016
Cc:
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Refactor android data deps pushing logic to not require //tools/swarming_client

Project Member Reported by jbudorick@chromium.org, Nov 7 2016 
isolate is a little more heavyweight than necessary & prevents non-chromium users of //build (e.g. pdfium, https://bugs.chromium.org/p/pdfium/issues/detail?id=415) from using data dependencies w/o also pulling in tools/swarming_client.

Comment 1 by jbudorick@chromium.org, Nov 10 2016

Summary: Refactor android data deps pushing logic to not require //tools/swarming_client (was: Refactor android data deps pushing logic to not required //tools/swarming_client)

Comment 2 by jbudorick@chromium.org, Nov 11 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3

commit 634c87cf4af7ac11f2dbe7687a6d7904c2217ee3
Author: jbudorick <jbudorick@chromium.org>
Date: Thu Nov 17 20:11:29 2016

[android] Stop using isolate.py for data dependency management.

BUG= 663110 

Review-Url: https://codereview.chromium.org/2492123002
Cr-Commit-Position: refs/heads/master@{#432940}

[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/PRESUBMIT.py
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/BUILD.gn
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/PRESUBMIT.py
[delete] https://crrev.com/89c538f4b15cb612c90605910bf2005142e46436/build/android/gn/generate_isolate.py
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/gyp/create_test_runner_script.py
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/pylib/base/test_instance_factory.py
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/pylib/gtest/gtest_test_instance.py
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/pylib/local/device/local_device_gtest_run.py
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/pylib/local/device/local_device_test_run.py
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/pylib/local/device/local_device_test_run_test.py
[add] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/pylib/utils/device_dependencies.py
[add] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/pylib/utils/device_dependencies_test.py
[delete] https://crrev.com/89c538f4b15cb612c90605910bf2005142e46436/build/android/pylib/utils/isolator.py
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/test_runner.py
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/android/test_runner.pydeps
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/config/android/internal_rules.gni
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/build/config/android/rules.gni
[delete] https://crrev.com/89c538f4b15cb612c90605910bf2005142e46436/build/secondary/tools/swarming_client/BUILD.gn
[delete] https://crrev.com/89c538f4b15cb612c90605910bf2005142e46436/build/secondary/tools/swarming_client/isolate.pydeps
[modify] https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3/testing/test.gni
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67002b0fdaa3123f10f96fa2f7965677d531db74

commit 67002b0fdaa3123f10f96fa2f7965677d531db74
Author: jbudorick <jbudorick@chromium.org>
Date: Fri Nov 18 02:12:19 2016

Revert of [android] Stop using isolate.py for data dependency management. (patchset #9 id:160001 of https://codereview.chromium.org/2492123002/ )

Reason for revert:
Breaks the blink bot, e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/57103

Original issue's description:
> [android] Stop using isolate.py for data dependency management.
>
> BUG= 663110 
>
> Committed: https://crrev.com/634c87cf4af7ac11f2dbe7687a6d7904c2217ee3
> Cr-Commit-Position: refs/heads/master@{#432940}

TBR=agrieve@chromium.org,dpranke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 663110 

Review-Url: https://codereview.chromium.org/2514453003
Cr-Commit-Position: refs/heads/master@{#433020}

[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/PRESUBMIT.py
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/BUILD.gn
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/PRESUBMIT.py
[add] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/gn/generate_isolate.py
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/gyp/create_test_runner_script.py
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/pylib/base/test_instance_factory.py
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/pylib/gtest/gtest_test_instance.py
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/pylib/local/device/local_device_gtest_run.py
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/pylib/local/device/local_device_test_run.py
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/pylib/local/device/local_device_test_run_test.py
[delete] https://crrev.com/49740e42977be69ae7c1af0f01df1758957c539b/build/android/pylib/utils/device_dependencies.py
[delete] https://crrev.com/49740e42977be69ae7c1af0f01df1758957c539b/build/android/pylib/utils/device_dependencies_test.py
[add] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/pylib/utils/isolator.py
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/test_runner.py
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/android/test_runner.pydeps
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/config/android/internal_rules.gni
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/config/android/rules.gni
[add] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/secondary/tools/swarming_client/BUILD.gn
[add] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/build/secondary/tools/swarming_client/isolate.pydeps
[modify] https://crrev.com/67002b0fdaa3123f10f96fa2f7965677d531db74/testing/test.gni
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d29ecfa7dc3ed49a2a49002ab941adb57c53e923

commit d29ecfa7dc3ed49a2a49002ab941adb57c53e923
Author: jbudorick <jbudorick@chromium.org>
Date: Fri Nov 18 22:45:42 2016

[android] Stop using isolate.py for data dependency management. (RELAND)

BUG= 663110 

Review-Url: https://codereview.chromium.org/2502363005
Cr-Commit-Position: refs/heads/master@{#433322}

[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/PRESUBMIT.py
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/BUILD.gn
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/PRESUBMIT.py
[delete] https://crrev.com/319f110637783ce562ad6092120441756572e644/build/android/gn/generate_isolate.py
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/gyp/create_test_runner_script.py
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/pylib/base/test_instance_factory.py
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/pylib/gtest/gtest_test_instance.py
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/pylib/local/device/local_device_gtest_run.py
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/pylib/local/device/local_device_test_run.py
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/pylib/local/device/local_device_test_run_test.py
[add] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/pylib/utils/device_dependencies.py
[add] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/pylib/utils/device_dependencies_test.py
[delete] https://crrev.com/319f110637783ce562ad6092120441756572e644/build/android/pylib/utils/isolator.py
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/test_runner.py
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/android/test_runner.pydeps
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/config/android/internal_rules.gni
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/build/config/android/rules.gni
[delete] https://crrev.com/319f110637783ce562ad6092120441756572e644/build/secondary/tools/swarming_client/BUILD.gn
[delete] https://crrev.com/319f110637783ce562ad6092120441756572e644/build/secondary/tools/swarming_client/isolate.pydeps
[modify] https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923/testing/test.gni

Comment 6 by jbudorick@chromium.org, Nov 22 2016

Status: Fixed (was: Started)
►

Sign in to add a comment