New issue
Advanced search Search tips

Issue 663108 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Stack tool broke for monochrome component build

Project Member Reported by michaelbai@chromium.org, Nov 7 2016

Issue description

It seemed that the tools failed to detect the library name.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3712de4fe0f696d46aba8ae9fb22658fc116596f

commit 3712de4fe0f696d46aba8ae9fb22658fc116596f
Author: michaelbai <michaelbai@chromium.org>
Date: Wed Nov 23 02:31:15 2016

stack: Detect library by name and arch

We were using name and size to detect library, this didn't work
when the relocation section is packed, in this case, the library
size doesn't match the one in APK.

BUG= 663108 

Review-Url: https://codereview.chromium.org/2525513003
Cr-Commit-Position: refs/heads/master@{#434088}

[modify] https://crrev.com/3712de4fe0f696d46aba8ae9fb22658fc116596f/third_party/android_platform/development/scripts/stack_core.py

Comment 2 by torne@chromium.org, Nov 23 2016

Shouldn't we be using the offset into the apk printed by debuggerd for this?
We did.
Status: Fixed (was: Untriaged)

Sign in to add a comment