New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663062 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

HTML elements cannot be clicked when using columns + hidden overflow + scrollLeft

Reported by ad...@tdsstudentlogin.com, Nov 7 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/602.2.14 (KHTML, like Gecko) Version/10.0.1 Safari/602.2.14

Example URL:

Steps to reproduce the problem:
Create a page with a div that has 2+ CSS columns, but only enough space to show 1 column, with overflow set to 'hidden'. Set the div's scrollLeft so you can only see the 2nd column. Make sure there's a <button> on the 2nd page. Note that you won't be able to click it. If the button was on the 1st page then you could click it as stuff on the 1st page works.

What is the expected behavior?
As above... you should be able to click on buttons regardless of what page they are one. This applies to ANY active content e.g. things with scroll bars, buttons, ...etc.

What went wrong?
I can't click the button (hovering over it also doesn't reflect style changes). I don't think the browser factors in the scrollLeft when figuring what the user is clicking on.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 54.0.2840.87  Channel: stable
OS Version: 7-10
Flash Version:  23.0.0.205-r1
 
Will update with the test page by cob or tomorrow.
Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Reporter@ Please provide us sample test file / URL to triage the issue further.

Thanks..
Attached is a test page and the image used. I need to update what I wrote as a plain button does work in Chrome, just fine... what doesn't work are scroll bars and iframe content. The attached test page demonstrates both.
 
If you resure the windows to a 'reasonable' size then the first page will have a button (labeled 'Test') at the top, animage with scroll bars (overflow is set to scroll), and an iFrame with a button in it labeled 'Test iFrame'. These all work on page 1.
 
But on page 2 the 'Test' button works, but the scroll bars on the image and the button in the iFrame do not. On Firefox these work fine.
reader5.html
28.0 KB View Download
the-monkeys-paw.jpg
73.1 KB View Download
This is a blocking support for Chrome Version 54. 
You didn't attach button.html can you provide that too?
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 24 2016

Labels: -Needs-Feedback Needs-Review
Owner: jmukthavaram@chromium.org
Thank you for providing more feedback. Adding requester "jmukthavaram@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Needs-Review Needs-Feedback
NextAction: 2016-11-30
Owner: ----
still waiting feedback
Attached button.html
button.html
154 bytes View Download
Cc: maxkirsch@chromium.org
Owner: dtapu...@chromium.org
Summary: HTML elements cannot be clicked when using columns + hidden overflow + scrollLeft (was: can't click the button (hovering over it also doesn't reflect style changes))
Here's a more minimal example: https://jsfiddle.net/j5h0tdf6/3/

Can you take a look dtapuska@?
Components: -Blink Blink>HitTesting
Owner: ----
Labels: -OS-Windows -Needs-Feedback Needs-Bisect OS-All
NextAction: ----
Status: Available (was: Unconfirmed)
RE comment #4: Are you implying that this worked in Chrome 53? Please confirm.

I'll request a bisect regardless, to get ahead of the problem if it is indeed a regression.
Labels: -Type-Bug -Needs-Bisect ReleaseBlock-Stable M-57 hasbisect Type-Bug-Regression
Owner: jbroman@chromium.org
Status: Assigned (was: Available)
Able to reproduce the issue on Win 10,Mac 10.11.6 and Ubuntu 14.04 using stable 55.0.2883.75 and canary 57.0.2944.0.

Bisect info(Unable to do per-revision-bisect as got script error as "We don't have enough builds to bisect."
========================
Good: 52.0.2715.0
Bad : 52.0.2716.0

You are probably looking for a change made after 389142 (known good), but no later than 389151 (first known bad).
CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/8b6d5f3c021f312bb13f4a4cf2c04bd8f1c5187f..98e094a1f352965d9ea46601f672b3555b56f330

Possible suspect from above CL:
Review URL: https://codereview.chromium.org/1879223002
jbroman@: Could you please take a look into this if its related to your change.
Added releaseblock-stable against M57 as its a recent regression.Please modify if not appropriate.
mstensho, have you had a chance to look into this?

Comment 15 by msten...@opera.com, Dec 16 2016

Unfortunately not, but here's a simplified test case.
tc.html
1.3 KB View Download
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90a520011b9e1f70355987371360540c922f4fc9

commit 90a520011b9e1f70355987371360540c922f4fc9
Author: mstensho <mstensho@opera.com>
Date: Tue Dec 20 09:42:50 2016

Make column snapping optional when translating to flow thread coordinates.

positionForPoint() wants this, but mapAncestorToLocal() requires that no
special behavior be applied.

While this CL doesn't fix  bug 663062 , it is a prerequisite for fixing it
without breaking existing tests (MulticolWithAbsPosNotContained in
MapCoordinatesTest unit test).

BUG= 663062 

Review-Url: https://codereview.chromium.org/2590463002
Cr-Commit-Position: refs/heads/master@{#439758}

[modify] https://crrev.com/90a520011b9e1f70355987371360540c922f4fc9/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
[modify] https://crrev.com/90a520011b9e1f70355987371360540c922f4fc9/third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp
[modify] https://crrev.com/90a520011b9e1f70355987371360540c922f4fc9/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
[modify] https://crrev.com/90a520011b9e1f70355987371360540c922f4fc9/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

Project Member

Comment 17 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/797ecc9d67798296b6c8fd2ced17f4716ccbb111

commit 797ecc9d67798296b6c8fd2ced17f4716ccbb111
Author: mstensho <mstensho@opera.com>
Date: Tue Dec 20 18:50:14 2016

Need to be inside the flow thread before converting a visual point.

Before we can convert from a visual point to a flow thread point, we need the
input point to be exactly relative to the flow thread, or we might end up
mapping it to the wrong column.

In other words, we need to add the flow thread object's location before
converting into the flow thread coordinate space. While the flow thread indeed
is at 0,0 (or at least close enough to 0,0) relatively to the multicol
container in very many cases, this isn't true when the multicol container is in
rtl writing-mode, or when it's scrollable, or even when the multicol container
has borders and/or padding.

BUG= 663062 

Review-Url: https://codereview.chromium.org/2593633002
Cr-Commit-Position: refs/heads/master@{#439855}

[modify] https://crrev.com/797ecc9d67798296b6c8fd2ced17f4716ccbb111/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/797ecc9d67798296b6c8fd2ced17f4716ccbb111/third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp

Comment 18 by msten...@opera.com, Dec 20 2016

Status: Fixed (was: Assigned)
Thanks guys. We'll look into this fix.
Labels: TE-Verified-57.0.2970.0 TE-Verified-M57
Tested this issue on windows-7, Mac-10.12.2 & Linux Ubuntu 14.04 using chrome Dev version#57.0.2970.0.

Observed that the scroll bars on the image and the button in the iFrame working fine. Hence the fix is working as expected.

Please find the attached screen cast for the same.

Adding TE-Verified labels.

Thanks.
663062.mp4
2.7 MB View Download

Sign in to add a comment