New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663061 link

Starred by 9 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 773935
issue 418185
issue 693293
issue 695976
issue 718203
issue 859822
issue 888082



Sign in to add a comment

official builders should have matching tryservers

Project Member Reported by dpranke@chromium.org, Nov 7 2016

Issue description

It's not good that we land changes on the branches that affect the official builders but have no way to test those changes ahead of time.

Ideally every official builder should have a matching tryserver.

Once the official builders are converted to recipes this should be much more doable.
 
Blockedon: 418185
I think that it's also important to be as close as we can from the official bots on this tryserver. This will mean that we'll need to run the official_[upload|signing|symbols] script to make sure that everything works fine. 
Agreed, we should run as much of the process as we can.
Cc: phajdan.jr@chromium.org
Labels: -Pri-3 Pri-2
Cc: -andyb...@chromium.org

Comment 5 by dimu@google.com, Feb 16 2017

Owner: dimu@chromium.org

Comment 6 by dimu@chromium.org, Feb 17 2017

Blockedon: 693293
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/d7d0c757a49923b8c30d6e9f240cd310627b2a92

commit d7d0c757a49923b8c30d6e9f240cd310627b2a92
Author: dimu <dimu@google.com>
Date: Fri Feb 24 00:23:22 2017

Comment 8 by dimu@google.com, Feb 24 2017

Blockedon: 695976
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/2cac68e3b61da723d3dd37408a9ac0724ef10f9d

commit 2cac68e3b61da723d3dd37408a9ac0724ef10f9d
Author: dimu <dimu@google.com>
Date: Mon Feb 27 19:20:16 2017

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 16 2017

Labels: merge-merged-config
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/b38561d9cbe9f4929d8eedd5be557b11b89b8739

commit b38561d9cbe9f4929d8eedd5be557b11b89b8739
Author: dimu <dimu@google.com>
Date: Thu Mar 16 18:22:44 2017

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/c6d6e656c0ddf870986b3316119cfff31436d8ba

commit c6d6e656c0ddf870986b3316119cfff31436d8ba
Author: dimu <dimu@google.com>
Date: Tue Mar 21 22:15:03 2017

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/2ebb518e244dfc2a4356193f4905dd582113bb1a

commit 2ebb518e244dfc2a4356193f4905dd582113bb1a
Author: dimu <dimu@google.com>
Date: Wed Mar 22 18:10:57 2017

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/3d1cce5bf6ad50624d88938d1537b4f723923b30

commit 3d1cce5bf6ad50624d88938d1537b4f723923b30
Author: dimu <dimu@google.com>
Date: Wed Mar 29 22:59:11 2017

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/8b024adb21dfa244ed87d148426a4d99608d9fe4

commit 8b024adb21dfa244ed87d148426a4d99608d9fe4
Author: dimu <dimu@google.com>
Date: Fri Mar 31 22:40:09 2017

Comment 15 by dimu@google.com, May 3 2017

Blockedon: 718203
Project Member

Comment 16 by bugdroid1@chromium.org, May 3 2017

Project Member

Comment 17 by bugdroid1@chromium.org, May 3 2017

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 15 2017

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a8eefb0f864bc20a19cbe794120a6e3e9dd61d08

commit a8eefb0f864bc20a19cbe794120a6e3e9dd61d08
Author: dimu <dimu@google.com>
Date: Fri Jun 30 03:48:50 2017

Enable Kitchen on internal.official.tryserver

R=dnj, iannucci

Bug:663061
Change-Id: Iad399c05b3f90ecd3ec2a75c4346377b203811a1
Reviewed-on: https://chromium-review.googlesource.com/557283
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Di Mu <dimu@chromium.org>

[modify] https://crrev.com/a8eefb0f864bc20a19cbe794120a6e3e9dd61d08/scripts/slave/remote_run.py

Comment 20 by dimu@chromium.org, Aug 8 2017

Owner: ----
Status: Untriaged (was: Available)

Comment 21 by mmoss@chromium.org, Jan 18 2018

Blockedon: 773935
Cc: -phajdan.jr@chromium.org -dimu@chromium.org amineer@chromium.org
dpranke@, can you summarize our current thinking on this? Are we willing to forego full internal tryservers and just have public branch builders[1], which should catch the vast majority of branch issues, but without the complications of failures/rejections that public contributors might not be able to see (I feel like there was actually another bug about doing exactly that, maybe from +amineer, but I can't find it right now).


[1] Once we have the public branches as the branch source-of-truth, as in Issue 773935

Comment 22 by mmoss@chromium.org, Jan 18 2018

Actually, your  Issue 773936  might be the other bug I'm thinking of. Should this just dupe into that?

Comment 23 by mmoss@chromium.org, Jan 19 2018

Owner: dpranke@chromium.org
Status: Assigned (was: Untriaged)
assigning to dpranke to decide if this should merge with  Issue 773936 
Cc: abdulsyed@chromium.org phajdan.jr@chromium.org anan...@chromium.org kbr@chromium.org jbudorick@chromium.org
 Issue 773936  has been merged into this issue.
Owner: ----
Status: Available (was: Assigned)
Yes, that bug was effectively a dup of this.

To answer the question in #c21, yes, we should have public builders at the very least, and then eventually if we can, also have private/official builders.

Comment 26 by mmoss@chromium.org, Jan 22 2018

Cc: -phajdan.jr@chromium.org
Owner: mmoss@chromium.org
Status: Assigned (was: Available)
Thanks. Assigning to me, at least for first step of getting to public branch builders, which is included in the plan for migrating branch source-of-truth from buildspecs to the source repos (Issue 773935).
Blockedon: 859822
Linked to  Issue 859822  to point out an example where trybots for the official builds would have prevented regressions from being introduced on a branch due to merge-backs.

Cc: -amineer@chromium.org
No longer on the Chrome team, e-mail me @google.com if any attention still required from me here, otherwise good luck!
Issue 331156 has been merged into this issue.
Blockedon: 888082
Cc: -iannucci@chromium.org iannu...@google.com

Sign in to add a comment