New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663058 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Moving suite_scheduler.ini broke the pre-submit hook

Project Member Reported by krisr@chromium.org, Nov 7 2016

Issue description

server $ repo upload .
Errors in PROJECT *chromiumos/third_party/autotest*!
    COMMIT 1a4c6fa2:
        Description:
            >Enable AT&T, Sprint, and T-Mobile nightlies.
            >
            >Enable these tests for the Nexus team.
            >
            >BUG=None
            >TEST=None
            >
            >Change-Id: Ie0509f48a5c3346572907039eafb2ba8ad63dcc7
            >
            >
        Errors:
            * Hook script "./site_utils/presubmit_hooks/check_suite_scheduler.py" failed with code 1:
              Traceback (most recent call last):
                File "./site_utils/presubmit_hooks/check_suite_scheduler.py", line 46, in <module>
                  main()
                File "./site_utils/presubmit_hooks/check_suite_scheduler.py", line 39, in main
                  output = utils.system_output(suite_scheduler + ' --sanity')
                File "/usr/local/google/home/krisr/cros/lab-admin-2/src/third_party/autotest/files/client/common_lib/base_utils.py", line 1043, in system_output
                  args=args).stdout
                File "/usr/local/google/home/krisr/cros/lab-admin-2/src/third_party/autotest/files/client/common_lib/base_utils.py", line 740, in run
                  "Command returned non-zero exit status")
              autotest_lib.client.common_lib.error.CmdError: Command </usr/local/google/home/krisr/cros/lab-admin-2/src/third_party/autotest/files/site_utils/suite_scheduler/suite_scheduler.py --sanity> failed, rc=1, Command returned non-zero exit status
              * Command: 
                  /usr/local/google/home/krisr/cros/lab-admin-2/src/third_party/autotest/fi
                  les/site_utils/suite_scheduler/suite_scheduler.py --sanity
              Exit status: 1
              Duration: 0.785538196564
              
              stderr:
              ERROR:root:Specified config file suite_scheduler.ini does not exist.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ed6e9536d7ab0f192db29e8249781367045336fd

commit ed6e9536d7ab0f192db29e8249781367045336fd
Author: Dan Shi <dshi@google.com>
Date: Wed Nov 09 22:09:10 2016

[autotest] Remove presubmit check for suite_scheduler.ini

The ini file was moved to a different repo, it no longer needs to be checked
in this repo.

BUG= chromium:663058 
TEST=None

Change-Id: If1d115067d13cf3573661444fc50ba714579bc41
Reviewed-on: https://chromium-review.googlesource.com/409710
Commit-Ready: Dan Shi <dshi@google.com>
Tested-by: Dan Shi <dshi@google.com>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/ed6e9536d7ab0f192db29e8249781367045336fd/PRESUBMIT.cfg

Comment 2 by dshi@chromium.org, Feb 15 2017

Status: Fixed (was: Assigned)

Sign in to add a comment