Issue 663055 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	hungte@chromium.org
Closed:	Nov 2016
Cc:	█ de...@chromium.org
Components:	Factory
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

possible missing dependency for factory-mini

Project Member Reported by amstan@chromium.org, Nov 7 2016

Issue description

I was looking at yellow stuff for veyron_rialto:
https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_rialto-release/builds/551/steps/BuildPackages%20%5Bafdo_use%5D/logs/stdio

Grep for "factory-mini".
Near the end:
WARNING: The following packages failed once or more,
but succeeded upon retry. This might indicate incorrect
dependencies.
  chromeos-base/factory-mini-0.0.1-r21

In the middle of the log i see this block:
factory-mini-0.0.1-r21: rsync: link_stat "/build/veyron_rialto/usr/lib/python2.7/site-packages/enum" failed: No such file or directory (2)
factory-mini-0.0.1-r21: rsync: link_stat "/build/veyron_rialto/usr/lib/python2.7/site-packages/google" failed: No such file or directory (2)
factory-mini-0.0.1-r21: rsync: link_stat "/build/veyron_rialto/usr/lib/python2.7/site-packages/jsonrpclib" failed: No such file or directory (2)

Is it possible that factory-mini does not have all the python lib dependencies?

Comment 1 by hungte@chromium.org, Nov 7 2016

Probably. A long term goal for our current migration is to deprecate factory-mini by simply chromeos-factory, but for now I can fix its dependency.

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/584bb13302e4156ea92935305229bd94cd71fc85

commit 584bb13302e4156ea92935305229bd94cd71fc85
Author: Hung-Te Lin <hungte@chromium.org>
Date: Mon Nov 07 22:58:12 2016

chromeos-base/factory-mini: Add missing dependencies.

The new factory build rules now always need complete environment to
generate resources for factory*.par (even the factory-mini) so
dependencies of chromeos-factory should be listed here as well.

BUG= chromium:663055 
TEST=./build_packages --board link

Change-Id: I6c9f720750052afea842476b7c28c099f46a548b
Reviewed-on: https://chromium-review.googlesource.com/407721
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Alexandru Stan <amstan@chromium.org>

[modify] https://crrev.com/584bb13302e4156ea92935305229bd94cd71fc85/chromeos-base/factory-mini/factory-mini-9999.ebuild