New issue
Advanced search Search tips

Issue 663053 link

Starred by 1 user
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Nov 2016
Cc:
yhirano@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

MojoAsyncResourceHandler continues watching for OnWriteable events on error

Project Member Reported by mmenke@chromium.org, Nov 7 2016 
Not sure if it's a real bug, or just an issue with unit tests, but MojoAsyncResourceHandler continues watching for OnWriteable messages after its cancelled a request due to error.  While I assume that Resume() will fail with the same error if this happens, if it doesn't, we're in an undefined state.  Let's be careful about that.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f12e05a01aba7dadd32003da6149d0a2f9cd3d52

commit f12e05a01aba7dadd32003da6149d0a2f9cd3d52
Author: mmenke <mmenke@chromium.org>
Date: Tue Nov 08 11:50:54 2016

MojoAsyncResourceHandler:  Ignore Resume/OnWritable calls after error.

If the Resume succeed after an error, we end up in an indeterminant
state, which would be bad.  Uncear if that can happen, but easy to
prevent it.

BUG= 663053 

Review-Url: https://codereview.chromium.org/2484933002
Cr-Commit-Position: refs/heads/master@{#430582}

[modify] https://crrev.com/f12e05a01aba7dadd32003da6149d0a2f9cd3d52/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/f12e05a01aba7dadd32003da6149d0a2f9cd3d52/content/browser/loader/mojo_async_resource_handler_unittest.cc

Comment 2 by mmenke@chromium.org, Nov 8 2016

Status: Fixed (was: Started)
►

Sign in to add a comment