Issue 663040 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	einbinder@chromium.org
Closed:	May 2017
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug

DevTools: Don't show autocomplete inside regular expressions

Project Member Reported by einbinder@chromium.org, Nov 7 2016

Issue description

If you are typing a regex in the console:

var x = /abcdef/g

we will autocomplete getComputedStyles off of the window.

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9de7313bdc84a44ab2935a6af66aabf15104159e

commit 9de7313bdc84a44ab2935a6af66aabf15104159e
Author: einbinder <einbinder@chromium.org>
Date: Thu Nov 10 20:50:24 2016

DevTools: Use CodeMirror syntax highlighting to improve JS autocomplete

This patch uses CodeMirror tokens to avoid giving suggestions when the
user is in a comment, string, or regular expression literal.

BUG= 663040 

Review-Url: https://codereview.chromium.org/2480423002
Cr-Commit-Position: refs/heads/master@{#431344}

[modify] https://crrev.com/9de7313bdc84a44ab2935a6af66aabf15104159e/third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions-expected.txt
[modify] https://crrev.com/9de7313bdc84a44ab2935a6af66aabf15104159e/third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html
[modify] https://crrev.com/9de7313bdc84a44ab2935a6af66aabf15104159e/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
[modify] https://crrev.com/9de7313bdc84a44ab2935a6af66aabf15104159e/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
[modify] https://crrev.com/9de7313bdc84a44ab2935a6af66aabf15104159e/third_party/WebKit/Source/devtools/front_end/ui/TextEditor.js

Comment 2 by einbinder@chromium.org, May 16 2017

Status: Fixed (was: Assigned)

►

Issue 663040 link

Issue metadata

DevTools: Don't show autocomplete inside regular expressions

Issue description

Comment 1 by bugdroid1@chromium.org, Nov 10 2016

Comment 1 Deleted

Comment 2 by einbinder@chromium.org, May 16 2017

Comment 2 Deleted

Sign in to add a comment